-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include names in argument lists #1408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
package:cupertino_http
Issues related to package:cupertino_http
label
Nov 19, 2024
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
liamappelbe
approved these changes
Nov 19, 2024
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 21, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/6af0821..1de8372): 1de83727 2024-11-20 Lasse R.H. Nielsen Implement full Unicode 16.0.0 extended grapheme breaking. (dart-lang/core#719) dartdoc (https://github.com/dart-lang/dartdoc/compare/f8a55e4..c7f1160): c7f11603 2024-11-20 Sam Rawlins Fix sidebars via correct web API for anchor href values (dart-lang/dartdoc#3934) http (https://github.com/dart-lang/http/compare/e37093f..79470d0): 79470d0 2024-11-19 Brian Quinlan Include names in argument lists (dart-lang/http#1408) shelf (https://github.com/dart-lang/shelf/compare/0bb44cb..a2708cd): a2708cd 2024-11-21 Devon Carew shorten the issue badges (dart-lang/shelf#456) Change-Id: Iee20d2300d1bf0e43a57b352b73235ae24fa5e51 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396960 Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.