Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use scss for styling #3916

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Use scss for styling #3916

wants to merge 5 commits into from

Conversation

parlough
Copy link
Member

@parlough parlough commented Oct 25, 2024 •
edited
Loading

This PR migrates the existing styles to use SCSS to benefit from nesting and so that some styles can be more easily shared with other Dart and Flutter related sites (particularly pub.dev) in the future.

It also enables minimization :)

srawlins
srawlins reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super bummer that git / GitHub cannot show a diff for the CSS -> SCSS. I'll have to just do a spot check. Or we could land the change more incrementally, unless you think that would be a huge feat.

@parlough
Copy link
Member Author

Or we could land the change more incrementally.

Sure, happy to do that - #3917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parlough @srawlins