-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple fonttools fixes #13
base: master
Are you sure you want to change the base?
Conversation
LGTM, but please squash the commits. |
I thought it is nicer to have them separate - besides it is easier to squash than to split a big one. I don't mind if you squash on merge (I think github gives you that choice). Not too sure about the actual content of the strings /symbols - for most part I just reuse the names, but I drop the "k" sometimes and also an ending "key" or middle "key" . I suspect the actual content is important at a later stage? For the time being they just need to be present. |
Oh, you didn't use the actual values? Please do — check what values the Apple version has. |
On commits: there is a point in having good, self-contained commits that change one thing at a time. But there's no point in 7 "add some more symbols" commits in a row 🙂 |
How do you check? I have the cross version of otool / nm if that helps. |
|
I meant how do you check if you have the genuine dylib (say, ask a friend to zip it up) but not the actual running OS... |
The same way, just link to that dylib (instead of the system copy) under Darling. |
The problem is that the genuine dylib has many other dependencies which does not load under darling, so does not run :-) . |
Oh, well. Then you're going to have to see what the symbol points to, and extract the |
Well, if genuine lib loads, I'd have just copied it over the darling ones :-). I'll see what I can do with those. It seems matching precisely is important.... |
I managed to hack at python ctypes to do lazy loading, and use darling python to look at some of the genuine libs. Btw, mach-o view seems to spin a lot and does nothing - is it supposed to work under darling? I tried "-NSOpen" like the other advice but it still spins. Perhaps somebody can update the doc if it is supposed to work... |
Has there been any progress on this? If not, I would be happy to help find the actual values. |
Various missing symbols required for Apple's font tool suite to run. Not sure about the sort order of things, but at least the changes go into the right files.
Please review.