Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16829 control: fix for daos pool query #15537

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wangshilong
Copy link
Contributor

Get basic pool info firstly, then update other rank lists sequentially.

Features: DmgPoolQueryRanks
Test-tag: pool_query
Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Get basic pool info firstly, then update other rank lists
sequentially.

Features: DmgPoolQueryRanks
Test-tag: pool_query
Required-githooks: true
Signed-off-by: Wang Shilong <[email protected]>
@wangshilong wangshilong requested review from a team as code owners November 26, 2024 02:34
Copy link

github-actions bot commented Nov 26, 2024

Ticket title is 'Regression with pool/query_attribute.py functional test'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16829

Copy link
Contributor

@knard-intel knard-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall PR seems good to me, however I am not sure on the pragma used which seems to restrictive for me. Instead of

Features: DmgPoolQueryRanks
Test-tag: pool_query

It should probably be better to use

Features: daos_cmd

src/control/cmd/daos/pool.go Outdated Show resolved Hide resolved
Features: daos_cmd
Required-githooks: true

Signed-off-by: Wang Shilong <[email protected]>
Copy link
Contributor

@tanabarr tanabarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a unit test that covers change in behaviour to avoid any regressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants