-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16829 control: fix for daos pool query #15537
base: master
Are you sure you want to change the base?
Conversation
Get basic pool info firstly, then update other rank lists sequentially. Features: DmgPoolQueryRanks Test-tag: pool_query Required-githooks: true Signed-off-by: Wang Shilong <[email protected]>
Ticket title is 'Regression with pool/query_attribute.py functional test' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall PR seems good to me, however I am not sure on the pragma used which seems to restrictive for me. Instead of
Features: DmgPoolQueryRanks
Test-tag: pool_query
It should probably be better to use
Features: daos_cmd
Features: daos_cmd Required-githooks: true Signed-off-by: Wang Shilong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a unit test that covers change in behaviour to avoid any regressions
Get basic pool info firstly, then update other rank lists sequentially.
Features: DmgPoolQueryRanks
Test-tag: pool_query
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: