Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16168 build: Ignore scons version deprecation (#14715) #14719

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

jolivier23
Copy link
Contributor

Disable warning for deprecated support for python
version so it doesn't fail the build.

Skip-test: true

Required-githooks: true

Change-Id: I7753b5e32e291fe748cddfe4caea2fc851b15e66

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Disable warning for deprecated support for python
version so it doesn't fail the build.

Skip-test: true

Required-githooks: true

Change-Id: I7753b5e32e291fe748cddfe4caea2fc851b15e66
Signed-off-by: Jeff Olivier <[email protected]>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Copy link

github-actions bot commented Jul 8, 2024

Bug-tracker data:
Ticket title is 'Functional on <> / FTEST_dfuse.DaosBuild.<>-./dfuse/daos_build.py:DaosBuild.test_dfuse_daos_build_wt_il'
Status is 'Awaiting backport'
Labels: 'request_for_2.6.1'
https://daosio.atlassian.net/browse/DAOS-16168

@jolivier23 jolivier23 merged commit 509745d into google/2.4 Jul 8, 2024
27 of 31 checks passed
@jolivier23 jolivier23 deleted the jvolivie/fix_build_2.4 branch July 8, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants