Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15753 dfuse: Do not deadlock when failing to mount. (#14252) #14274

Merged
merged 1 commit into from
Apr 30, 2024
Merged

DAOS-15753 dfuse: Do not deadlock when failing to mount. (#14252) #14274

merged 1 commit into from
Apr 30, 2024

Conversation

jolivier23
Copy link
Contributor

Required-githooks: true

Change-Id: Ia8452f68990f495e42e8af2e8a1eb7c951fbbdfa

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@ashleypittman @jolivier23
DAOS-15753 dfuse: Do not deadlock when failing to mount. (#14252)
fb610c4 
Required-githooks: true

Change-Id: Ia8452f68990f495e42e8af2e8a1eb7c951fbbdfa
Signed-off-by: Ashley Pittman <[email protected]>
@jolivier23 jolivier23 requested a review from mjmac April 29, 2024 16:25
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'dfuse deadlocking when failing to start.'
Status is 'Resolved'
https://daosio.atlassian.net/browse/DAOS-15753

daosbuild1
daosbuild1 reviewed Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@jolivier23 jolivier23 merged commit ca43ed2 into google/2.4 Apr 30, 2024
33 of 35 checks passed
@jolivier23 jolivier23 deleted the jvolivie/deadlock branch April 30, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@mjmac mjmac mjmac approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jolivier23 @mjmac @daosbuild1 @ashleypittman