Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b/334917514 - Add daos fs chown #14184

Merged
merged 1 commit into from
Apr 18, 2024
Merged

b/334917514 - Add daos fs chown #14184

merged 1 commit into from
Apr 18, 2024

Conversation

juszhan1
Copy link
Collaborator

@juszhan1 juszhan1 commented Apr 18, 2024

Example usage:

// Original state
[juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0
drwxr-xr-x   1 juszhan_google_com juszhan_google_com   120 Apr 17 23:53 dfuse0
-rw-r--r--   1 juszhan_google_com juszhan_google_com  9146 Apr 17 23:53 dfuse0.log

// Change group to a known group id
[juszhan_google_com@juszhan-dev daos]$ getent group 1001
tmpuserjohn:x:1001:

[juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1001 --dfs-path=/
Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1001 --dfs-path=/

[juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0
drwxr-xr-x   1 juszhan_google_com tmpuserjohn          120 Apr 17 23:53 dfuse0
-rw-r--r--   1 juszhan_google_com juszhan_google_com  9146 Apr 17 23:53 dfuse0.log

// Change group to a nonexistent group id
[juszhan_google_com@juszhan-dev daos]$ getent group 1002

[juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1002 --dfs-path=/
Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1002 --dfs-path=/

[juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0
drwxr-xr-x   1 juszhan_google_com               1002   120 Apr 17 23:53 dfuse0
-rw-r--r--   1 juszhan_google_com juszhan_google_com  9146 Apr 17 23:53 dfuse0.log

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

Bug-tracker data:
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/b/334917514

Copy link
Contributor

@jolivier23 jolivier23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. Since this is upstream visible, can you add text for usage rather that an internal link?

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Example usage:
// Original state
[juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0
drwxr-xr-x   1 juszhan_google_com juszhan_google_com   120 Apr 17 23:53 dfuse0
-rw-r--r--   1 juszhan_google_com juszhan_google_com  9146 Apr 17 23:53 dfuse0.log

// Change group to a known group id
[juszhan_google_com@juszhan-dev daos]$ getent group 1001
tmpuserjohn:x:1001:

[juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1001 --dfs-path=/
Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1001 --dfs-path=/

[juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0
drwxr-xr-x   1 juszhan_google_com tmpuserjohn          120 Apr 17 23:53 dfuse0
-rw-r--r--   1 juszhan_google_com juszhan_google_com  9146 Apr 17 23:53 dfuse0.log

// Change group to a nonexistent group id
[juszhan_google_com@juszhan-dev daos]$ getent group 1002

[juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1002 --dfs-path=/
Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1002 --dfs-path=/

[juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0
drwxr-xr-x   1 juszhan_google_com               1002   120 Apr 17 23:53 dfuse0
-rw-r--r--   1 juszhan_google_com juszhan_google_com  9146 Apr 17 23:53 dfuse0.log

Required-githooks: true

Signed-off-by: Justin Zhang <[email protected]>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14184/2/testReport/

@juszhan1 juszhan1 merged commit 7da45c7 into google/2.4 Apr 18, 2024
33 of 36 checks passed
@juszhan1 juszhan1 deleted the juszhan1/chown branch April 18, 2024 18:20
jolivier23 pushed a commit that referenced this pull request Jul 26, 2024
Example usage:
// Original state
[juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0
drwxr-xr-x   1 juszhan_google_com juszhan_google_com   120 Apr 17 23:53 dfuse0
-rw-r--r--   1 juszhan_google_com juszhan_google_com  9146 Apr 17 23:53 dfuse0.log

// Change group to a known group id
[juszhan_google_com@juszhan-dev daos]$ getent group 1001
tmpuserjohn:x:1001:

[juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1001 --dfs-path=/
Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1001 --dfs-path=/

[juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0
drwxr-xr-x   1 juszhan_google_com tmpuserjohn          120 Apr 17 23:53 dfuse0
-rw-r--r--   1 juszhan_google_com juszhan_google_com  9146 Apr 17 23:53 dfuse0.log

// Change group to a nonexistent group id
[juszhan_google_com@juszhan-dev daos]$ getent group 1002

[juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1002 --dfs-path=/
Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1002 --dfs-path=/

[juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0
drwxr-xr-x   1 juszhan_google_com               1002   120 Apr 17 23:53 dfuse0
-rw-r--r--   1 juszhan_google_com juszhan_google_com  9146 Apr 17 23:53 dfuse0.log

Required-githooks: true

Change-Id: I5a4870cdabe4e96fd772fb824d9ba71dc9dd88b1
Signed-off-by: Justin Zhang <[email protected]>
Signed-off-by: Jeff Olivier <[email protected]>
jolivier23 added a commit that referenced this pull request Jul 26, 2024
Example usage:
// Original state
[juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0
drwxr-xr-x   1 juszhan_google_com juszhan_google_com   120 Apr 17 23:53 dfuse0
-rw-r--r--   1 juszhan_google_com juszhan_google_com  9146 Apr 17 23:53 dfuse0.log

// Change group to a known group id
[juszhan_google_com@juszhan-dev daos]$ getent group 1001
tmpuserjohn:x:1001:

[juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1001 --dfs-path=/
Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1001 --dfs-path=/

[juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0
drwxr-xr-x   1 juszhan_google_com tmpuserjohn          120 Apr 17 23:53 dfuse0
-rw-r--r--   1 juszhan_google_com juszhan_google_com  9146 Apr 17 23:53 dfuse0.log

// Change group to a nonexistent group id
[juszhan_google_com@juszhan-dev daos]$ getent group 1002

[juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1002 --dfs-path=/
Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1002 --dfs-path=/

[juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0
drwxr-xr-x   1 juszhan_google_com               1002   120 Apr 17 23:53 dfuse0
-rw-r--r--   1 juszhan_google_com juszhan_google_com  9146 Apr 17 23:53 dfuse0.log

Required-githooks: true

Change-Id: I5a4870cdabe4e96fd772fb824d9ba71dc9dd88b1

Signed-off-by: Justin Zhang <[email protected]>
Signed-off-by: Jeff Olivier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants