-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
b/334917514 - Add daos fs chown #14184
Conversation
Bug-tracker data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine. Since this is upstream visible, can you add text for usage rather that an internal link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Example usage: // Original state [juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0 drwxr-xr-x 1 juszhan_google_com juszhan_google_com 120 Apr 17 23:53 dfuse0 -rw-r--r-- 1 juszhan_google_com juszhan_google_com 9146 Apr 17 23:53 dfuse0.log // Change group to a known group id [juszhan_google_com@juszhan-dev daos]$ getent group 1001 tmpuserjohn:x:1001: [juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1001 --dfs-path=/ Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1001 --dfs-path=/ [juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0 drwxr-xr-x 1 juszhan_google_com tmpuserjohn 120 Apr 17 23:53 dfuse0 -rw-r--r-- 1 juszhan_google_com juszhan_google_com 9146 Apr 17 23:53 dfuse0.log // Change group to a nonexistent group id [juszhan_google_com@juszhan-dev daos]$ getent group 1002 [juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1002 --dfs-path=/ Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1002 --dfs-path=/ [juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0 drwxr-xr-x 1 juszhan_google_com 1002 120 Apr 17 23:53 dfuse0 -rw-r--r-- 1 juszhan_google_com juszhan_google_com 9146 Apr 17 23:53 dfuse0.log Required-githooks: true Signed-off-by: Justin Zhang <[email protected]>
6fe9595
to
c45ef57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14184/2/testReport/ |
Example usage: // Original state [juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0 drwxr-xr-x 1 juszhan_google_com juszhan_google_com 120 Apr 17 23:53 dfuse0 -rw-r--r-- 1 juszhan_google_com juszhan_google_com 9146 Apr 17 23:53 dfuse0.log // Change group to a known group id [juszhan_google_com@juszhan-dev daos]$ getent group 1001 tmpuserjohn:x:1001: [juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1001 --dfs-path=/ Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1001 --dfs-path=/ [juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0 drwxr-xr-x 1 juszhan_google_com tmpuserjohn 120 Apr 17 23:53 dfuse0 -rw-r--r-- 1 juszhan_google_com juszhan_google_com 9146 Apr 17 23:53 dfuse0.log // Change group to a nonexistent group id [juszhan_google_com@juszhan-dev daos]$ getent group 1002 [juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1002 --dfs-path=/ Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1002 --dfs-path=/ [juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0 drwxr-xr-x 1 juszhan_google_com 1002 120 Apr 17 23:53 dfuse0 -rw-r--r-- 1 juszhan_google_com juszhan_google_com 9146 Apr 17 23:53 dfuse0.log Required-githooks: true Change-Id: I5a4870cdabe4e96fd772fb824d9ba71dc9dd88b1 Signed-off-by: Justin Zhang <[email protected]> Signed-off-by: Jeff Olivier <[email protected]>
Example usage: // Original state [juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0 drwxr-xr-x 1 juszhan_google_com juszhan_google_com 120 Apr 17 23:53 dfuse0 -rw-r--r-- 1 juszhan_google_com juszhan_google_com 9146 Apr 17 23:53 dfuse0.log // Change group to a known group id [juszhan_google_com@juszhan-dev daos]$ getent group 1001 tmpuserjohn:x:1001: [juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1001 --dfs-path=/ Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1001 --dfs-path=/ [juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0 drwxr-xr-x 1 juszhan_google_com tmpuserjohn 120 Apr 17 23:53 dfuse0 -rw-r--r-- 1 juszhan_google_com juszhan_google_com 9146 Apr 17 23:53 dfuse0.log // Change group to a nonexistent group id [juszhan_google_com@juszhan-dev daos]$ getent group 1002 [juszhan_google_com@juszhan-dev daos]$ run_cmd daos fs chown pool cont -g 1002 --dfs-path=/ Running DAOS_AGENT_DRPC_DIR=/tmp/agent daos fs chown pool cont -g 1002 --dfs-path=/ [juszhan_google_com@juszhan-dev daos]$ ls -la /tmp | grep dfuse0 drwxr-xr-x 1 juszhan_google_com 1002 120 Apr 17 23:53 dfuse0 -rw-r--r-- 1 juszhan_google_com juszhan_google_com 9146 Apr 17 23:53 dfuse0.log Required-githooks: true Change-Id: I5a4870cdabe4e96fd772fb824d9ba71dc9dd88b1 Signed-off-by: Justin Zhang <[email protected]> Signed-off-by: Jeff Olivier <[email protected]>
Example usage:
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: