Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request title #14178

Closed
wants to merge 2 commits into from
Closed

Pull request title #14178

wants to merge 2 commits into from

Conversation

jolivier23
Copy link
Contributor

Update

@jolivier23
Simple change
3bad640 
Required-githooks: true

Change-Id: Iaf5ab14d029ecfd800b1733750ac63b56c17681f
Signed-off-by: Jeff Olivier <[email protected]>
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Pull

daosbuild1
daosbuild1 reviewed Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@jolivier23
test failure
f754c4b 
Required-githooks: true

Change-Id: I98b8e40a73884583cba3f76fd15b31f21e9c7bcd
Signed-off-by: Jeff Olivier <[email protected]>
daosbuild1
daosbuild1 reviewed Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@jolivier23 jolivier23 closed this Apr 17, 2024
@jolivier23 jolivier23 deleted the jvolivie/test branch April 17, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jolivier23 @daosbuild1