-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new HWO Input Catalog #53
base: master
Are you sure you want to change the base?
Conversation
Also tested and debugged function in generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the other functions, I recommend changing dist_max
to d_max
. Also, either change m_V_max
to Vmag_max
or change the magnitude names in HPIC.txt to m_V
, m_J
, etc. Otherwise, addition of this function and the HPIC.txt file does not affect the rest of the Bioverse code and can be merged.
If I make these changes to my HPIC_integration branch, will it automatically update it in this pull request, or would I need to make a new request? |
Now is more consistent with the names of properties in bioverse
@nwtuchow, if you just push a new commit to your fork |
Yes, I made a change on my end earlier, and I saw that it updated the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed all changes between master
and nwtuchow:HPIC_integration and all looks good to me.
However, I don't have the bandwidth to actually test the new functionality right now - sorry. @kevinkhu were you able to run a quick test? Otherwise I can try next week.
I agree that there is little chance that merging this would break Bioverse. Still, before merging I think we should at a minimum:
- make a generator that includes the new HPIC function
- actually generate the planets
- see if the resulting Table object contains what is expected.
In any case, great work on this new addition to Bioverse!!
@nwtuchow Where would be a good place(s) in the documentation to mention the possibility of planet generation with HPIC? |
I think it might make sense to discuss it in the "Generating Planetary systems" section of the documentation. I think it would be also be helpful to describe the different options for the generator that are included with bioverse, such as the different functions for planet occurrence rates, generating host stars . The read_HPIC function could be described alongside the other functions |
I've added the HPIC: The Habitable Worlds Preliminary Input Catalog of Tuchow, Stark, and Mamajek (2024) to the data directory and added a function to read it in functions.py. This branch added the functionality to use a new input catalog and does not affect other areas of Bioverse. I've tested the new function and it appears to work properly.
The file size of the HPIC.txt file has been reduced to only include the relevant properties that Bioverse uses. If there are additional stellar properties from the full HPIC catalog (hosted here) which would be useful for Bioverse please let me know.