updated workflow #156
Merged
updated workflow #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for taking care of that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking to use this project with my new rt3200 and i saw this issue #141
I thought, I could contribute something here, so I worked up a modern version that uses minimal actions and gh cli for release + uploading.
It run off tags pushed or via a tag inputted when run manually, with an option to just build + artifacts and not release (for testing?)
It also only releases if the build job was successful.
If anything just to show a modern way to do it without needing certain actions. If you wanted a good action instead of gh cli you can use this https://github.com/ncipollo/release-action
Though, gh cli is really the best thing to use when you can, simple and official.