Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rahul's changes #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rahulk29
Copy link

@rahulk29 rahulk29 commented Nov 3, 2022

No description provided.

derive Copy, Clone for Point. derive Default for Rect, Polygon, Path

derive Default, Copy for BoundBox. impl BoundBoxTrait for Rect

fix layout bbox

fix bug

add instance alignment methods

format, fix bug in gds exporter

add reflect_vert_anchored

upgrade deps

add some align modes

bugfixes for empty bbox, more align modes

upgrade chrono

make Rect Copy

Make outline in abstract view optional

warning: tests not passing

add shape and add port APIs

add git dependency on vlsir

Update to get layers by spec

port set net

add alignment methods

align, bbox, data, geom

update rect, span, ports

GDS importer generates abstract

text label reading, direction agnostic Rect APIs

fix trailing whitespace, gds/geom updates

update

update layout 21

port merging

Make GDS error Send + Sync

Send + Sync error handling

Send + Sync error handling

update layers API to allow querying for layers and update gitignore

add get_purps API for Layers

add traits to LayerSpec

add Ord and PartialOrd to LayerSpec

Instance builder

Instance builder does not take &self as parameter

Add Point::zero method

Add ability to find cells in a library

Make Instance::loc default to origin when using InstanceBuilder

Add empty check when converting Rect from BoundBox

better error messages when getting ports from abstract views

Span::expand method

Add Cell::empty method

cargo fmt

AbstractPort::named method

Update readme to point to dan-fritchman/Layout21

typo

Create Layout::add_pin method

Cell add pin methods

Add Span::merge method

Use IntoIterator

Correct implementation of Span::merge using IntoIterator

Rect::expanded method

Rect::expand_dir

Add Layout::draw_rect method

Add ports_starting_with method to Instance

Add Cell::layout getter method

Add Cell::abs getter method

Hack layout21 to preserve text elements on non-label layers

Mark element nets if text is on pin or label

Add print statement

fix: import floating text elements correctly
@dan-fritchman
Copy link
Owner

Per yesterday 11/3's meeting with @growly & @aviralpandey:

  • Gotta support VLSIR, it's our primary on-disk format. Not just GDSII.
    • A good test for these changes would be: run the command-line tools gds2proto and proto2gds back-to-back, and (at least "semantically") compare the round-tripped GDS files.
  • We've all pretty much admitted that as little as we like them, we probably need GDSII-style "layered" or "3D located" text labels.
    • Adding these to layout.raw.LayerShapes, and then adding the code to import and export them, would probably do it
  • We did not review the layer-manager changes, and should before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants