Feature update sept24 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Param: revRegen - toggle regen on and off in reverse PumpPWM - Output pin function is now selectable FanTemp - inverter or charger temp at which Cooling fan Out goes high TachoPPR - Pulses per revolution for driving tachos Added Classic Vehicle - has tacho output and uses 12V inputs for vehicle states Also includes Nissan Leaf BMS framework Also includes tapering to limits - to be verified on vehicle
Tom-evnut
requested review from
damienmaguire and
jsphuebner
as code owners
|
All issues review and nothing creates problems as far as I can tell. All are additions not removing. |
damienmaguire
approved these changes
Sep 26, 2024
|
Thanks Tom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Param:
revRegen - toggle regen on and off in reverse
PumpPWM - Output pin function is now selectable
FanTemp - inverter or charger temp at which Cooling fan Out goes high
TachoPPR - Pulses per revolution for driving tachos
Added spotvalue
TorqueDerate - sets any time potnom derates, clears at next precharge cycle.
Added Classic Vehicle - has tacho output and uses 12V inputs for vehicle states
Also includes Nissan Leaf BMS framework
Leaf Inverter setup for Leaf BMS and precharge UDC control, Included ignore init UDC reading
Clean up shunt type - Type 0-none makes sure that UDC gets forced 0 at Opmode==OFF
Also includes tapering to limits - to be verified on vehicle
GS450h - Shifting does not impact torque on MG1, to be tested on vehicle. Due to changes of Oilpump pwm verify rest of Comms not impacted.