Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin used version of the .NET CLI to .NET 8.x.x #5936

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Pin used version of the .NET CLI to .NET 8.x.x #5936

merged 3 commits into from
Nov 28, 2024
+7 −0

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Nov 27, 2024 •
edited
Loading

Description

  • Pin used version of the .NET CLI to .NET 8.x.x
  • Use a specific version of System.Runtime.Handles

How has this been tested?

Will turn on run-deep-tests to see if this fixes CI on Windows.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer added the run-deep-tests Tells CI to run all tests label Nov 27, 2024
@keyboardDrummer keyboardDrummer enabled auto-merge (squash) November 28, 2024 11:28
@keyboardDrummer keyboardDrummer changed the title Use a specific version of System.Runtime.Handles Pin used version of the .NET CLI to .NET 8.x.x Nov 28, 2024
MikaelMayer
MikaelMayer approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already had a global.json in my directory but it was using "version": "8.0.403", is the version 111 picked because of something special?

@keyboardDrummer keyboardDrummer merged commit 00b97e1 into dafny-lang:master Nov 28, 2024
26 of 31 checks passed
@keyboardDrummer
Copy link
Member Author

I already had a global.json in my directory but it was using "version": "8.0.403", is the version 111 picked because of something special?

There's a feature rollForward policy so picking the lowest 8.x.x version allows using any 8.x.x version.

@keyboardDrummer keyboardDrummer deleted the explicitHandlesVersion branch November 28, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikaelMayer MikaelMayer MikaelMayer approved these changes

Assignees
No one assigned
Labels
run-deep-tests Tells CI to run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keyboardDrummer @MikaelMayer