Fix issue 5554 soundness #5874
Merged
Fix issue 5554 soundness #5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of int to avoid overflows
typerSniper
reviewed
Nov 6, 2024
Source/IntegrationTests/TestFiles/LitTests/LitTest/git-issues/git-issue-5554.dfy
Outdated
Show resolved
Hide resolved
Source/IntegrationTests/TestFiles/LitTests/LitTest/git-issues/git-issue-5554.dfy.expect
Outdated
Show resolved
Hide resolved
typerSniper
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Dafny CS runtime to use BigIntegers instead of int32 when retrieving the number of elements in a multiset. As this number may be over INT_MAX, this change avoids potential overflows. This is similar to what is done in the Java runtime.
How has this been tested?
A test was added: Source/IntegrationTests/TestFiles/LitTests/LitTest/git-issues/git-issue-5554.dfy
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.