Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat simplified rust identifiers #5845

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

MikaelMayer
Copy link
Member

Description

Previously, Dafny was emitting escaped identifiers using the prefix "r#", which was useless as it's equivalent for Rust to "".
I had to fix the proofs.

How has this been tested?

Existing tests should pass

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

ssomayyajula
ssomayyajula previously approved these changes Oct 20, 2024
Copy link
Contributor

@ssomayyajula ssomayyajula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great idea to aggregate the unsupported features encountered rather than throwing an exception immediately.

Copy link
Contributor

@ssomayyajula ssomayyajula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-rolling

@MikaelMayer
Copy link
Member Author

I'll revisit this PR when the fix for newtypes is pushed, as it also fixes a potential infinite loop that this PR hits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants