-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alpaca mitigations #5061
Draft
elliefm
wants to merge
11
commits into
cyrusimap:master
Choose a base branch
from
elliefm:v311/alpaca-mitigations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
alpaca mitigations #5061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(details subject to change after we get some data about what tags IMAP clients in the wild are sending to our servers) |
elliefm
force-pushed
the
v311/alpaca-mitigations
branch
from
November 11, 2024 02:41
9f9067a
to
96e275b
Compare
Needs #5126 to land first |
elliefm
force-pushed
the
v311/alpaca-mitigations
branch
from
November 12, 2024 22:24
96e275b
to
bf62745
Compare
since it's about to get more complicated than just isatom
reduces surface area for cross-protocol reflection attacks against web browsers
It already did, but this early short-circuit was overlooked at the time (This isn't strictly related to this PR, but while I'm in here anyway...)
elliefm
force-pushed
the
v311/alpaca-mitigations
branch
from
November 24, 2024 23:49
bf62745
to
fd4f32d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following mitigations that prevent Cyrus IMAP servers being used in Application Layer Protocol Confusion (ALPACA) attacks, particularly against web browsers:
<>
characters (prevents reflecting attacker-supplied HTML content in IMAP responses):
characters (HTTP request header lines now count as basic syntax errors)Fixes #5046