retire custom manpage generator #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliefm
force-pushed
the
v39/retire-custom-manpage-generator
branch
from
bf96543
to
43256e7
Compare
rjbs
approved these changes
Aug 9, 2023
elliefm
added
backport-to-3.6
Why is the current one broken with newer libraries? I don't know! But we also no longer know why we had a custom builder, either. At first glance, the output without the custom code seems fine. We should inspect it more, and then we can decide if we can go forward with this and also delete the custom code!
elliefm
force-pushed
the
v39/retire-custom-manpage-generator
branch
from
43256e7
to
d6b2c08
Compare
elliefm
removed
backport-to-3.8
This was referenced Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #4555
Switches our docs build to use the stock sphinx manpage generator, rather than the custom one that keeps getting broken by new sphinx releases (thanks @rjbs), and then removes the parts we're no longer using.
I think I've removed everything that needed removing, but it shouldn't hurt if I've missed stuff.
Reviewers: please test this -- it works fine for me, but does it work for you?
make man-- should exit success. There will be a bunch of warnings ("duplicate term", "glob pattern didn't match", "document isn't included in any doctree") but these can be ignored, unless they're different from what I've listed.man/directory.ls -l man/* | wc -lgives 84 for me. Check that they're not empty! Also check a couple of them to ensure they look okay:man man/imapd.conf.5etc.git clean -xfd, though n.b. this will trash uncommitted files)docsrcdirectorymake manin here -- you do not need to have run configure for this!docsrc/build/man, check those too as per step 3.