Provide support for BigDecimal use with float_filter #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error here looks like a Travis CI rvm configuration issue rather than an issue with the code committed. |
|
Accepting BigDecimal inputs sounds reasonable 👍 It looks like there are other changes on your branch now though - do you want to remove them so I can merge this pull request, or would you prefer that I cherry-pick the BigDecimal commit manually? |
|
I will edit the PR to have a dedicated branch for the Numeric change. If I think any of the other changes I have made for my own projects will be useful I will open in separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into issues in my tests where I used model.attributes to provide my inputs (e.g. for updates) where I am storing values as BigDecimal instead of Float.
Using
Numericinstead ofFixnumshould still work well with.to_fbut will include support forBigDecimalas input.All tests pass so I don't think I have gone against some intended behaviour. Let me know if you have any questions?