Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport unit types #378

Merged
merged 1 commit into from
Jul 16, 2024
Merged

transport unit types #378

merged 1 commit into from
Jul 16, 2024

Conversation

nuclearkatie
Copy link
Contributor

Forgot that transportunits have their own type

@nuclearkatie nuclearkatie self-assigned this Jul 15, 2024
@nuclearkatie
Copy link
Contributor Author

uh oh, not sure why we should be having build problems with such a simple change

@bennibbelink
Copy link
Contributor

Hmm I agree... looks like an issue with dependencies. I'll try to pinpoint the issue, stay tuned

@bennibbelink bennibbelink mentioned this pull request Jul 15, 2024
Merged
@bennibbelink
Copy link
Contributor

Was able to resolve the issue by using conda-forges versions of sphinx, etc. I think we had an older version of jinja trying to be used by a newer version of sphinx. See #379.

@nuclearkatie
Copy link
Contributor Author

nuclearkatie commented Jul 15, 2024 •
edited
Loading

🙏 so speedy at getting a PR opened, thank you @bennibbelink. After #379 is merged I'll rebase and this will be ready fro a review

@nuclearkatie nuclearkatie marked this pull request as ready for review July 16, 2024 02:29
gonuke
gonuke approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I can't seem to figure out where in the built pages this makes a difference, though.

@gonuke gonuke merged commit b76d431 into cyclus:source Jul 16, 2024
2 checks passed
@nuclearkatie
Copy link
Contributor Author

@gonuke nowhere... yet! TransportUnits aren't in Storage yet, but they're coming soon and it made sense to do the uitypes at the same time as Cyclus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

@bennibbelink bennibbelink Awaiting requested review from bennibbelink

Assignees

@nuclearkatie nuclearkatie

Labels
None yet
Projects
None yet
Milestone
Create/update documentation
Development

Successfully merging this pull request may close these issues.
3 participants
@nuclearkatie @bennibbelink @gonuke