-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update publications #374
Update publications #374
Conversation
Build is failing due to some of the new packaging features:
Looks like there are a few sets of hardcoded types in |
Yeah I raised this in #373. I was gonna fix it in conjunction with some other packaging documentation but I'll put in a quick fix just for this now that other people are looking to push updates to the website |
Thanks @bennibbelink and @nuclearkatie. Tests are passing now and this should be good for someone to review. |
0cedd47
to
f757d29
Compare
The commit I just made should make it so that the publications are listed in the order the appear in There is a way to write our own custom style/sorting in Sphinx but that feels like overkill for the number of publications we list |
Thanks for adding that in @bennibbelink. I've reordered the bib files to be in reverse order. We still need a review on this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @abachma2 for updating this
This PR addresses #371, by adding the v1.6 citations and adding some newer publications. In #371 I asked about the ordering of the publications, but it's not clear to me how the literature and presentation sections get ordered, as it isn't the order of the bib file.