Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publications #374

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Update publications #374

merged 5 commits into from
Jul 8, 2024

Conversation

abachma2
Copy link
Member

This PR addresses #371, by adding the v1.6 citations and adding some newer publications. In #371 I asked about the ordering of the publications, but it's not clear to me how the literature and presentation sections get ordered, as it isn't the order of the bib file.

@bennibbelink
Copy link
Contributor

Build is failing due to some of the new packaging features:

  File "/cyclus.github.com/source/cyclusagent.py", line 164, in _type
    raise TypeError(msg.format(given))
TypeError: Note that 'package' is not a valid XML schema data type, see http://www.w3.org/TR/xmlschema-2/ for more information.

Looks like there are a few sets of hardcoded types in cyclusagent.py (lines 104-153), @nuclearkatie do you know what specifically needs to be added to that script to accommodate your recent work?

@nuclearkatie
Copy link
Contributor

Yeah I raised this in #373. I was gonna fix it in conjunction with some other packaging documentation but I'll put in a quick fix just for this now that other people are looking to push updates to the website

@nuclearkatie nuclearkatie mentioned this pull request Jun 30, 2024
@bennibbelink
Copy link
Contributor

#373 has been addressed by #375. With a rebase this should be ready to review @abachma2

@abachma2
Copy link
Member Author

abachma2 commented Jul 1, 2024

Thanks @bennibbelink and @nuclearkatie. Tests are passing now and this should be good for someone to review.

@bennibbelink
Copy link
Contributor

bennibbelink commented Jul 1, 2024

The commit I just made should make it so that the publications are listed in the order the appear in pubs.bib. You can manually reorder them in that file to your liking (reverse chronological seems fine to me). This worked for me locally, let me know if you run into issues

There is a way to write our own custom style/sorting in Sphinx but that feels like overkill for the number of publications we list

@abachma2
Copy link
Member Author

abachma2 commented Jul 8, 2024

Thanks for adding that in @bennibbelink. I've reordered the bib files to be in reverse order. We still need a review on this PR

Copy link
Contributor

@nuclearkatie nuclearkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @abachma2 for updating this

@nuclearkatie nuclearkatie merged commit b6f8cc1 into cyclus:source Jul 8, 2024
2 checks passed
@abachma2 abachma2 mentioned this pull request Jul 18, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants