Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ResourceBuff #370

Merged
merged 2 commits into from
May 20, 2024
Merged

Deprecate ResourceBuff #370

merged 2 commits into from
May 20, 2024

Conversation

bennibbelink
Copy link
Contributor

  • Updates the toolkit documentation to reflect the deprecation of ResourceBuff
  • Updates Dockerfile to use python3 instead of version agnostic python

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering about the placement of the deprecation note.

You can read the `ResourceBuff API documentation
<http://fuelcycle.org/cyclus/api/classcyclus_1_1toolkit_1_1ResourceBuff.html>`_ for
more details on how to use the buffer.
ResourceBuff has been deprecated in favor of ``ResBuf``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder where it is best to include this note? Maybe at the end of the ResBuf preamble?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here?

image

@gonuke gonuke merged commit 50b43a6 into cyclus:source May 20, 2024
2 checks passed
@bennibbelink bennibbelink deleted the resource-buff branch May 20, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants