-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cep28 #291
base: source
Are you sure you want to change the base?
cep28 #291
Conversation
@@ -0,0 +1,54 @@ | |||
CEP 26 - Generalize the DRE to Optimize Multiple Metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CEP 26 - Generalize the DRE to Optimize Multiple Metrics | |
CEP 28 - Additional Control Input to Manage RecordTimeSeries |
:CEP: 28 | ||
:Title: Additional Control Input to Manage RecordTimeSeries | ||
:Last-Modified: 3/1/2019 | ||
:Author: Robert Flanagan \& Gwen Chee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:Author: Robert Flanagan \& Gwen Chee | |
:Author: Robert Flanagan \& Gwendolyn Chee |
file. While this has yet to impact performance, it is conceivable | ||
that it could become problematic in the future. To combat this | ||
a new cyclus control input field will be added to allow users to | ||
choose which RecordTimeSeries tables to be added to the output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we decided on an on and off toggle, rather than specifically choosing which tables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On: all the tables
off: the tables that existed in Cyclus before the addition recordtimeseries in the various Cycamore archetypes.
Default is off?
|
||
Motivation | ||
========== | ||
The addition of the TimeSeriesListeners added to support the d3ploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of the TimeSeriesListeners added to support the d3ploy | |
The addition of the TimeSeriesListeners functionality in the d3ploy |
cause an increased storage space for each run. As this data is unused | ||
by any simulation not using the listeners, it is just wasted hard disk | ||
space. This charge will be used to mitigate this problem. It will also | ||
allow uses to run a simulation that outputs only the specific tables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allow uses to run a simulation that outputs only the specific tables | |
allow users to run a simulation that outputs only the specific tables |
This charge will add a field to the simulation control that will allow | ||
the user to specify which tables they wish to see. By default this value | ||
will be set to all tables, but if user wishes to specify the tables they | ||
wish to see they will do so by entering the string of each table's name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really necessary? Because if a user is using d3ploy to deploy a specific facility, they would probably want to see the table that is associated with that facility and they would probably not have other cycamore facilities in the simulation so those tables won't show up anyway.
Any thoughts on resurrecting this @FlanFlanagan @gwenchee ? |
@gwenchee
This is work in progress do not merge