Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimming with Volume Buttons #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kian-shirazi
Copy link

This feature allows the user to control the brightness of the flashlight right after the volume buttons are used to turn it on. The default is to give a 2 second window to make these adjustments, this is adjustable in the UI via settings.

…tons after using the double-volume button shortcut to activate the flashlight.

The interval is user-adjustable in the UI.
@cyb3rko
Copy link
Owner

cyb3rko commented Sep 11, 2024

Thanks for your contribution, I like the idea.
Before merging, I would like to make some adjustments:

  • allow option only if volume buttons service is activated, otherwise it does not have any effect
  • disable by default
  • change icon to something time related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants