Nc/75 acl ui

[narinearraul]

Resolves #75
Resolves #74
Resolves #79

Proposed Changes:

• Edit and Delete buttons hidden when no data is selected
• Nodes created from dataviewer have default ACL now
• ACL div cleared when no info
• Clearing selectedNode in the tree when nothing is selected + error handling of when selectedNode is null

DCO1.1 Signed-off-by: Narine Cholakyan [email protected]

[boopt2]

Hi narinearraul,

Thanks for submitting this pull request!

I can confirm that the DCO1.1 sign-off has been included. It is okay to process this pull request.

dco-bot

[krbrewer]

I would suggest we remove flex from the right panel, when the height of the window changes some of the text overlaps. If the data viewer is only used out of mobile we could add a min-height to keep text from overlapping.

[krbrewer]

When I add a node to a csync that is empty and then delete that node, I am unable to add any more new nodes. After deleting the first node the add button turns grey and won't allow adding more nodes until refreshing the page.

[narinearraul]

@krbrewer #79

[boopt2]

I found a bug.

Make node a.
make node a.b
Make node a.b.c
Write "test" to a.b.c.
Hit refresh
Expected Behavior: See "test" when a.b.c loads
Actual Behavior: See nothing until a.b.c is reselected

EDIT: It seems to not be initializing empty nodes as well, I need to reselect them on refresh before I can interact with them.

Another bug:
Make node a.
Delete node a.
Expected behavior: Can create more nodes
Actual:Unable to make any more nodes, add node is greyed out.
This may be what @krbrewer was mentioning.

Doing things during the create flow is weird too. Lets sit down later today and try to sort thru some of these @narinearraul

[boopt2]

Some bugs documented on the comments we should fix before approving

[narinearraul]

@krbrewer #82

[narinearraul]

@boopt2 I've addressed #79 here also. Could you test and merge if all good?

[boopt2]

Looks good, but due to the large number of states in the code, some more comments couldn't hurt.