Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: gRPC server should not be recommended to be enabled by default #80

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Problem: gRPC server should not be recommended to be enabled by default #80

wants to merge 4 commits into from

Conversation

calvinaco
Copy link
Contributor

Solution: Update to recommend disable gRPC server

@calvinaco calvinaco changed the title Problem: gRPC server is recommended to be enabled by default Problem: gRPC server should not be recommended to be enabled by default Nov 28, 2021
@calvinaco
Copy link
Contributor Author

/staging

@calvinaco
Copy link
Contributor Author

/staging

tomtau
tomtau reviewed Nov 29, 2021
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should API etc. also be disabled on public nodes? or some other recommendation -- e.g. IP-restrict it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomtau tomtau tomtau left review comments

@landanhu landanhu Awaiting requested review from landanhu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calvinaco @tomtau