This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Windows: PageVisibility API when any other window goes fullscreen #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cr-Commit-Position: refs/branch-heads/2564@{#516}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
It may happen that the audio parameters returned by a hardware device are invalid for Chromium. If the invalidity is caused only by having too many output channels, return the maximum allowed channels to make sure there are no serialization problems. This does not matter in practice, as streams are created using the input channels. BUG=568860 NOTRY=true NOPRESUBMIT=true TBR= Review URL: https://codereview.chromium.org/1542103002 Cr-Commit-Position: refs/heads/master@{#368316} (cherry picked from commit 2d0a4f0) Review URL: https://codereview.chromium.org/1573753002 Cr-Commit-Position: refs/branch-heads/2564@{#517} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
BUG=505838 NOTRY=true NOPRESUBMIT=true TBR= Review URL: https://codereview.chromium.org/1567393004 Cr-Commit-Position: refs/heads/master@{#368389} (cherry picked from commit 61e67a3) Review URL: https://codereview.chromium.org/1571303003 Cr-Commit-Position: refs/branch-heads/2564@{#518} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Old icons were removed in M47 and there is thus no reason to support using an alternate icon index anymore. BUG=570366 Review URL: https://codereview.chromium.org/1543853002 Cr-Commit-Position: refs/heads/master@{#368086} (cherry picked from commit 0e35f1c) Conflicts: chrome/installer/util/master_preferences.h chrome/installer/util/master_preferences_unittest.cc [email protected], [email protected] Review URL: https://codereview.chromium.org/1571343002 . Cr-Commit-Position: refs/branch-heads/2564@{#519} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
BUG=541415 Review URL: https://codereview.chromium.org/1437523005 Cr-Commit-Position: refs/heads/master@{#360130} (cherry picked from commit 297ae87) Review URL: https://codereview.chromium.org/1576073002 . Cr-Commit-Position: refs/branch-heads/2564@{#520} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
…a word in the web content the Look Up dialog should pop up for the word. BUG=481890 Review URL: https://codereview.chromium.org/1528153004 Cr-Commit-Position: refs/heads/master@{#368481} (cherry picked from commit 927f273) Review URL: https://codereview.chromium.org/1575113002 . Cr-Commit-Position: refs/branch-heads/2564@{#521} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
ContainerNode::parserRemoveChild is the only consumer of ContainerNode::removeBetween that doesn't defer widget updates during the call. This could potentially lead to problems with scripts running at an inopportune time. This patch adds a RAII guard that runs deferred widget updates at the end of parserRemoveChild. [email protected] BUG=560011 Review URL: https://codereview.chromium.org/1464223002 Cr-Commit-Position: refs/heads/master@{#363154} (cherry picked from commit 05926d6) Review URL: https://codereview.chromium.org/1574913003 . Cr-Commit-Position: refs/branch-heads/2564@{#522} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
> [DevTools] Fix custom user agent override not applying. > > BUG=575029 > > Review URL: https://codereview.chromium.org/1569023002 > > Cr-Commit-Position: refs/heads/master@{#368224} TBR=pfeldman (cherry picked from commit e9b238a) Review URL: https://codereview.chromium.org/1574003002 . Cr-Commit-Position: refs/branch-heads/2564@{#523} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Cr-Commit-Position: refs/branch-heads/2564@{#524}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
…m tray it em for transient views. SystemTray::ShowItems gets called by SystemTrayItem::PopupDetailedView. The fo\ rmer has some logic to detect when ChromeVox is on. If so, it tries to focus t\Fix volume slider to emit value changed events and do not focus system\ tray item for transient views. SystemTray::ShowItems gets called by SystemTrayItem::PopupDetailedView. The fo\ rmer has some logic to detect when ChromeVox is on. If so, it tries to focus t\ he first item. This is problematic because PopupDetailedView is transient and \ disappears. The general bug is that ChromeVox gets the focus event and flips itself to com\ -UU-:----F1 cl_descriptionbhyjBt Top L1 (Fundamental) ------------------ For information about GNU Emacs and the GNU system, type C-h C-a. -UUU:----F1 *scratch* All L1 (Fundamental) -------------------------- Warning: Unknown defun property `special' in gfeeds-find # Enter a description of the change. Fix volume slider to emit value changed events and do not focus system tray it\ em for transient views. SystemTray::ShowItems gets called by SystemTrayItem::PopupDetailedView. The fo\ rmer has some logic to detect when ChromeVox is on. If so, it tries to focus t\Fix volume slider to emit value changed events and do not focus system tray item for transient views. SystemTray::ShowItems gets called by SystemTrayItem::PopupDetailedView. The former has some logic to detect when ChromeVox is on. If so, it tries to focus the first item. This is problematic because PopupDetailedView is transient and disappears. The general bug is that ChromeVox gets the focus event and flips itself to compat mode. However, true focus still lives in the web content. BUG=559339 NOTRY=true NOPRESUBMIT=true TBR= Review URL: https://codereview.chromium.org/1523953004 Cr-Commit-Position: refs/heads/master@{#365565} (cherry picked from commit b6cac2b) Review URL: https://codereview.chromium.org/1577973002 Cr-Commit-Position: refs/branch-heads/2564@{#525} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
We don't really handle GetVideoStreamTextureProgram() returning null gracefully, so avoid the crash. However, any broken implementation that was crashing here will still not render embedded videos and cause GL errors (since successfull shader compilation and use of GLenums are also gated on the extension). BUG=350443 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1515723002 Cr-Commit-Position: refs/heads/master@{#364263} (cherry picked from commit 46c8803) Review URL: https://codereview.chromium.org/1579633003 . Cr-Commit-Position: refs/branch-heads/2564@{#526} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Repro steps: 1.) Open NTP (in tabbed mode) 2.) Rotate landscape and scroll toolbar to top 3.) Long press on an NTP item and open in incognito 4.) Open tab switcher and switch back to normal stack 5.) Rotate to portrait 6.) Select NTP Turns out in this case an onScrollChanged is not broadcast from the scroll view so we need to push one ourselves. BUG=548088 Review URL: https://codereview.chromium.org/1460503005 Cr-Commit-Position: refs/heads/master@{#360734} Review URL: https://codereview.chromium.org/1581463002 . Cr-Commit-Position: refs/branch-heads/2564@{#527} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
This updates from revision df1735751c24e736018dc51f1be7dea686b6304 (2015-11-12) to revision 3594dcfbd8cf1cb3ba2c57bd56b761147ea31fca (2016-01-04) [email protected] BUG=37436 Review URL: https://codereview.chromium.org/1569853004 Cr-Commit-Position: refs/heads/master@{#368490} (cherry picked from commit c9c3a68) Review URL: https://codereview.chromium.org/1573203004 . Cr-Commit-Position: refs/branch-heads/2564@{#528} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Script tags with an integrity attribute were making two network requests for the same resource for each tag. This would only happen if the script tag appeared in the HTML of the page, but not if it was added programmatically. This was because the preloader was requesting the resource, but not checking the integrity attribute, and when the actual request came around, it had to re-request the resource because of the integrity metadata (see https://chromium.googlesource.com/chromium/src/+/175dcb80d2d369bd7ce55b46d72971395c21a932 for a description of why this re-request for scripts is needed if there is no integrity metadata on the first request). Thus the solution to this is to check the integrity metadata in the preloader. This adds a check in the preloader where, if the resource is a script, it checks the integrity attribute and adds the appropriate integrity metadata. When the script is requested for real later, the returned resource now has the integrity metadata and no re-request is needed. BUG=573269 Review URL: https://codereview.chromium.org/1561903002 Cr-Commit-Position: refs/heads/master@{#367888} (cherry picked from commit 271be40) Review URL: https://codereview.chromium.org/1578993002 . Cr-Commit-Position: refs/branch-heads/2564@{#529} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
This fixes a bug where a script loaded after a previous script failed due to an integrity failure would also fail to load. This is because the PendingScript object was reused for the new script resource, and we failed to clear out the m_integrityFailure bit. This simply sets that to false when the old script resource is released. BUG=570340 Review URL: https://codereview.chromium.org/1569823004 Cr-Commit-Position: refs/heads/master@{#368379} (cherry picked from commit 2a03de6) Review URL: https://codereview.chromium.org/1579503004 . Cr-Commit-Position: refs/branch-heads/2564@{#530} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Otherwise a method-only change does not cause dependent jars to be rebuilt. Review URL: https://codereview.chromium.org/1573023002 Cr-Commit-Position: refs/heads/master@{#368604} (cherry picked from commit 1b4abd1) BUG=550410 Review URL: https://codereview.chromium.org/1579803002 . Cr-Commit-Position: refs/branch-heads/2564@{#531} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Virtual functions were unnecessarily added to InvalidationSet by https://codereview.chromium.org/1317533002 These have a memory cost when there are many style rules and/or many elements scheduled for style invalidation. BUG=556531 Review URL: https://codereview.chromium.org/1480973002 Cr-Commit-Position: refs/heads/master@{#363166} (cherry picked from commit 580ea70) Review URL: https://codereview.chromium.org/1580503004 . Cr-Commit-Position: refs/branch-heads/2564@{#532} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
BUG=576183 Review URL: https://codereview.chromium.org/1577183002 . Cr-Commit-Position: refs/branch-heads/2564@{#533} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Cr-Commit-Position: refs/branch-heads/2564@{#534}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
BUG=576490 Review URL: https://codereview.chromium.org/1578013002 Cr-Commit-Position: refs/heads/master@{#368753} (cherry picked from commit cff89e9) Review URL: https://codereview.chromium.org/1577173003 . Cr-Commit-Position: refs/branch-heads/2564@{#535} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Now requires the user to check "Always user this app". BUG=576490 Review URL: https://codereview.chromium.org/1575163002 Cr-Commit-Position: refs/heads/master@{#368774} (cherry picked from commit 3d24f09) Review URL: https://codereview.chromium.org/1571383004 . Cr-Commit-Position: refs/branch-heads/2564@{#536} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Usually a valid MemoryCacheEntry holds a non-null Resource as |m_resource|. But when we hold a valid MemoryCacheEntry beyond destructive statements, it may be evicted from the cache and get stale. That means |m_resource| can be null in such cases. This CL checks it in order to avoid null dereference. BUG=488373 Review URL: https://codereview.chromium.org/1537343002 Cr-Commit-Position: refs/heads/master@{#367802} (cherry picked from commit 843010f) Review URL: https://codereview.chromium.org/1576113006 . Cr-Commit-Position: refs/branch-heads/2564@{#537} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
CSP's matching algorithm has been updated to make clever folks like Yan slightly less able to gather data on user's behavior based on CSP reports[1]. This matches Firefox's existing behavior (they apparently changed this behavior a few months ago, via a happy accident[2]), and mitigates the CSP-variant of Sniffly[3]. On the dashboard at https://www.chromestatus.com/feature/6653486812889088. [1]: w3c/webappsec-csp@0e81d81 [2]: https://bugzilla.mozilla.org/show_bug.cgi?id=1218524#c2 [3]: https://bugzilla.mozilla.org/show_bug.cgi?id=1218778#c7 BUG=544765,558232 Review URL: https://codereview.chromium.org/1455973003 Cr-Commit-Position: refs/heads/master@{#360562} (cherry picked from commit 568075b) Review URL: https://codereview.chromium.org/1581573002 . Cr-Commit-Position: refs/branch-heads/2564@{#538} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Due to bug 570699, it's sometimes possible not to have any current SessionEntry/NavgitionItem. In that case, don't attempt to store POST data on the item. BUG=574195,570699 Review URL: https://codereview.chromium.org/1575683002 Cr-Commit-Position: refs/heads/master@{#368484} (cherry picked from commit 8deee5e) Review URL: https://codereview.chromium.org/1578253002 . Cr-Commit-Position: refs/branch-heads/2564@{#539} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Previously, if the PreferenceFragment was recreated after returning to the preference after attempting to delete a saved password, the password list wouldn't be available and PasswordManagerPresenter would fail to delete the password. Now, password deletion is handled by PasswordEntryEditor, which always updates the password list before attempting to delete. BUG=575370 [email protected] Review URL: https://codereview.chromium.org/1571513003 Cr-Commit-Position: refs/heads/master@{#368785} Review URL: https://codereview.chromium.org/1583503002 . Cr-Commit-Position: refs/branch-heads/2564@{#540} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
https://helpx.adobe.com/security/products/flash-player/apsb16-01.html BUG=412078 [email protected] Review URL: https://codereview.chromium.org/1577003003 Cr-Commit-Position: refs/heads/master@{#368727} (cherry picked from commit 4fbe8b9) Review URL: https://codereview.chromium.org/1580033002 . Cr-Commit-Position: refs/branch-heads/2564@{#541} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
This is a merge to M48 of f003b7d . Avoid calling clientWidth early to get the control panel width. It can cause a crash when the HitTestCache is cleared, if the cache was the last holder to the media element. Normally, this can't happen, but a callback from the WebMediaPlayer can be scheduled between the cache becoming the last reference and the next layout. BUG=531259 NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1578853002 Cr-Commit-Position: refs/branch-heads/2564@{#542} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
…o websites. Presently, when logins from Android apps are filled into the corresponding websites and are used for a successful login, the user is prompted to save a new credential, and ultimately a copy of the credential, keyed by the web site, gets saved to the password store. This is a very confusing UX, and also results in duplicate logins being created. Later, these can lead to an out-of-date password stored for the Android app if the Web password is ever updated in the future. Instead, in this scenario, do not prompt at all, do not save any new credentials, but simply update the usage count of the existing Android credential in-place while leaving the other meta-attributes untouched. BUG=540609 [email protected] Review URL: https://codereview.chromium.org/1571813002 Cr-Commit-Position: refs/heads/master@{#368421} (cherry picked from commit 90098fd) Review URL: https://codereview.chromium.org/1578003004 . Cr-Commit-Position: refs/branch-heads/2564@{#543} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
The lock is static because we make many instances of InvalidationPreferences but only one can be committing at a time. BUG=568369 Review URL: https://codereview.chromium.org/1512183002 Cr-Commit-Position: refs/heads/master@{#364410} (cherry picked from commit dea09d3) Review URL: https://codereview.chromium.org/1580153002 . Cr-Commit-Position: refs/branch-heads/2564@{#544} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
WebView uses ContentViewCore's context for displaying dialogs and wraps it at construction time. This change makes sure that if there is an activity that can be reached through WindowAndroid, we use that as the context inside ColorChooser. Also make sure if there is no activity, we dont attempt to create a color chooser and try to show it. Update ActivityWindowAndroid to take a Context type so that in Android WebView, the activity context can remain wrapped. This change is a combination of https://codereview.chromium.org/1419843002 and https://codereview.chromium.org/1572913003 and in general changes WindowAndroid behavior so that a Context reference is kept rather than an Activity reference and makes it possible to use a ContextWrapper. BUG=550410, 570429 [email protected] Review URL: https://codereview.chromium.org/1578353002 . Cr-Commit-Position: refs/branch-heads/2564@{#545} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
This patch includes in-depth allocation tracker and extention of protocol.json by stackEntryLine that is used for total time annotations in CPU profiling Details of HeapProfiler: Three new commands were added by analogy with Chrome DevTools allocation tracker. Start/Stop and Event which is sent by timer. Command stopTrackingHeapXDK accepts three parameters: stack depth for unwinding, Sample After Value - period of timer and a flag to collect retention information or not. Event sends to the host currently collected data about symbols/callstack/objects. Command stopTrackingHeapXDK returns the final info witch is similar to Event passed format with one more parameter: duration of the collection. Basing on this info consumer can build allocation call tree for any period of time, annotate source by self and total allocation mertics and annotate allocation call tree by the objects, which retain other objects in the memory. P.S.: This is a refactoring of the XDK patches for blink-crosswalk. Some blink functionality was moved from one place to another and we had to rework the patch. The original patches are: 3c5a049, 89c615a, 0626260 in blink-crosswalk. BUG=XWALK-5109 [M48 notes: adapted to the following upstream changes: - https://codereview.chromium.org/1362973004 - https://codereview.chromium.org/1405823002]
As part of the efforts to stop depending on external packages in the code, replace usage of org.apache.http classes with an implementation that only uses apache.net.Uri. This allows us to drop the dependency on the legacy_http_client target and end up having to bundle org.apache.http.legacy.jar into xwalk_core_library.jar. Not upstreamable, as the code in question was removed upstream when they dropped support for ICS. BUG=XWALK-5092
The demo at https://storage.googleapis.com/presentation-api/index.html can be used to see how the API is works. The Crosswalk Presentation API implementation on Windows requires having a connected non-primary display (either wired (HDMI, Display Port, ...) or wireless (miracast)). BUG=XWALK-4811
Unlike WebView, XWalkView uses a ContentView object as its child view, which is actually receiving all kinds of events such as touching and clicking. To let the XWalkView object receive these events too, it's necessary to override relevant methods of ContentView and redirect them to the XWalkView object. So we add XWalkContentView and have it extend ContentView. To make this possible, the contructor of ContentView must be public. XWalkContentView is a temporary solution. We are targeting to optimize the hierarchy of XWalkView to make it more like WebView. This task can be tracked via XWALK-6118. BUG=XWALK-6014
Add Intel RSSDK based video capture device VideoCaptureDeviceRSWin. It allows: 1. Crosswalk apps to share the RealSense camera with other native apps simultaneously. 2. Crosswalk apps to use getUserMedia API to preview RealSense camera in real-time while accessing RSSDK middlewares in Crosswalk extensions simultaneously. This feature is behind "use_rssdk" build flag and "use-rs-video-capture" runtime flag. TEST= On a device with RealSense camera and RSSDK, execute 1. DF_RawStreams.exe (RSSDK sample) 2. xwalk.exe --use-rs-video-capture https://webrtc.github.io/samples/src/content/devices/input-output/ Crosswalk and DF_RawStreams.exe should capture video frames from RealSense camera simultaneously. BUG=XWALK-6028
…ts are used. Backported so that we can launch our Windows bots from the Windows Task Scheduler. Original commit message: This bit of code was added in 2010 by commit 66ae36f ("Restricting lifetime of python sync server on Windows via a JobObject"). The rationale at the time was that running a test case under a debugger would associate all new processes with the debugger's job object. Since 2010, Windows 8 and others have been releases, all of which support nested jobs and do not require processes to be created with the CREATE_BREAKAWAY_FROM_JOB. Not only that, but unconditionally setting that flag prevents browser tests from the Windows Task Scheduler at least on Windows 8 and later: the Task Scheduler creates a job object to launch the test(s), and calling CreateProcess() with that flag resulted in an access denied error (error number 5). Not setting it allows children processes to be created and attached to new job objects in addition to the Task Scheduler one. TEST=interactive_ui_tests, content_browsertests from the Windows Task Scheduler (set the task to only run when the user is logged in, otherwise the processes are launched from session 0) [email protected],[email protected],[email protected],[email protected] Review URL: https://codereview.chromium.org/1546313002 BUG=XWALK-5142
The same issue in libyuv also affects us. Original commit message: In java_cpp_enum.py there were assumptions on 'build' being a component of the absolute path of the script invoking the script. This leads to problems when other projects are using the Chromium build toolchain (in this case libyuv), where the script invoking GYP is located in the root of the project dir (https://chromium.googlesource.com/libyuv/libyuv/+/master/gyp_libyuv). BUG=libyuv:536 Review URL: https://codereview.chromium.org/1571243003 BUG=XWALK-5749
This change (together with a follow-up in the Crosswalk repository itself) moves the definition of the ENABLE_WEBCL macro to Blink's features.gypi, so that it is only passed to the relevant modules and bindings files intead of all the 15000+ files part of Crosswalk's build. This part of the fix only adds the definition to the Blink side; the Crosswalk patch will stop defining the macro for the other files.
While chromium is bundling xinput1_3.dll from DirectX redist, using whatever platform suports. Logic about what dll is in use for different platforms is copied from Xinput.h. In order to target all of the Windows versions with the same binary, chosen to keep dynamic linking approach. Otherwise, there would be a problem with XInputEnable not available in xinput dll before Windows8 and deprecated on Windows 10. Snippet from <ProgramFiles>\Windows Kits\10\Include\10.0.10586.0\um\Xinput.h: \#if(_WIN32_WINNT >= _WIN32_WINNT_WIN8) \#define XINPUT_DLL_A "xinput1_4.dll" \#define XINPUT_DLL_W L"xinput1_4.dll" \#else \#define XINPUT_DLL_A "xinput9_1_0.dll" \#define XINPUT_DLL_W L"xinput9_1_0.dll" \#endif For detailed information on Windows library loading and search path priorities, check https://msdn.microsoft.com documentation on LoadLibrary(). Upstreaming the patch planned, too.
BUG=XWALK-5503 Some OSs (e.g. Windows and Linux) don't mark windows as hiden on screen lock or when other opaque windows fully cover them. Note that e.g. OSX and Android do this while Windows and Linux don't. OnSoftVisibilityChanged enables that OS window state is kept as is (on Linux and Windows) and that e.g. power saving PageVisibility API is still properly triggered. The first patch here targets Windows and screen lock. branch pagevis
Page Visibility API: visibilitychange on Windows screen lock/unlock
BUG=XWALK-5002 [windows] App does not support orientation lock On Windows 8 and later, fullscreen is not mandatory to get application prefered locking. Patch here implements Screen orientation lock API for Windows.
Screen orientation lock implementation for Windows
…een. BUG=XWALK-5503 Some OSs (e.g. Windows and Linux) don't mark windows as hidden on screen lock or when other opaque windows fully cover them. The patch here targets Windows and window from any process going fullscreen. For this, AppBar notifications are used. Note that this covers e.g. VLC, MS Paint or browsers going fullscreen. It doesn't cover screensaver or when application windows are maximized. In the case when current window goes fullscreen, appbar notificaion is also received. This case is handled, too.
|
Testing patch series with astojilj/chromium-crosswalk@48602f4 as its head.
|
|
@darktears, @pozdnyakov |
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
Small typo in the original change, https://codereview.chromium.org/1811753003/ BUG=594465, 593593, 590683, 593624, 593593 [email protected],[email protected] Review URL: https://codereview.chromium.org/1814323002 Cr-Commit-Position: refs/heads/master@{#382309} (cherry picked from commit d0298a9) Review URL: https://codereview.chromium.org/1818123003 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#326} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
fujunwei
pushed a commit
to fujunwei/chromium-crosswalk
that referenced
this pull request
May 27, 2016
These requests are now handled through a javascript hack to work around this webkit bug: https://bugs.webkit.org/show_bug.cgi?id=145410. BUG=489692 Review URL: https://codereview.chromium.org/1375023002 Cr-Commit-Position: refs/heads/master@{#363256} (cherry picked from commit 8d13d52) Review URL: https://codereview.chromium.org/1516303002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#326} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Previously, routing info are encoded in the iq node. When the host is offline, the talk network responds with an error IQ that doesn't get relayed to the client because it doesn't have the routing info that the signaling service needs. Since an error IQ always contain the original request, by moving the routing info inside the original jingle request, we can reliably route the error message back to the client. Review-Url: https://codereview.chromium.org/2042513002 Cr-Commit-Position: refs/heads/master@{#398383} (cherry picked from commit 046534d) BUG=618143 Review URL: https://codereview.chromium.org/2061503002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#326} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
Two small fixes: 1. The fling velocity threshold needs to be lowered to 6. 2. Dragging up on the launcher sometimes transitions to peeking, this is because we check that abs(drag_offset) > drag_threshold, but don't check the sign of the offset. [email protected] (cherry picked from commit 6fea42a) Bug: 765845 Change-Id: I22270e4caea5b4aab22b347b1ce28e98a5df03fe Reviewed-on: https://chromium-review.googlesource.com/669944 Commit-Queue: Alex Newcomer <[email protected]> Reviewed-by: Xiyuan Xia <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#502720} Reviewed-on: https://chromium-review.googlesource.com/673372 Reviewed-by: Alex Newcomer <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#326} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG=XWALK-5503
Some OSs (e.g. Windows and Linux) don't mark windows as hidden on screen
lock or when other opaque windows fully cover them.
The patch here targets Windows and window from any process going fullscreen.
For this, AppBar notifications are used.
Note that this covers e.g. VLC, MS Paint or browsers going fullscreen. It
doesn't cover screensaver or when application windows are maximized.
In the case when current window goes fullscreen, appbar notificaion is also
received. This case is handled, too.