-
Notifications
You must be signed in to change notification settings - Fork 80
Workload Labeling Proposal #200
base: master
Are you sure you want to change the base?
Conversation
@wonderflow I doubt whether there is a more 'strict' way for an OAM user to set the label |
design/workload-labeling.md
Outdated
|
||
## Proposal | ||
|
||
Step 1: Setting the label `definition.oam.dev/unique-pod` as the unique identifier of pods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we create a new field in workloadDefinition.spec instead of using a label.
design/workload-labeling.md
Outdated
|
||
- For OAM users | ||
|
||
We recommend you to set label `definition.oam.dev/unique-pod` in WorkloadDefinition and Component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WorkloadDefinition is created by Platform builder
design/workload-labeling.md
Outdated
|
||
## Best practice | ||
|
||
- For OAM users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like using OAM users
here, it can't be understood clearly.
We general distinguish users by
- Platform builder
- Application Operator
- Application Developer
What do you mean by saying OAM user here? If I understood you clearly, you may mean platform builder here? A platform builder won't forget anything if they are building service for their users. |
Signed-off-by: 天元 <[email protected]> Signed-off-by: zzxwill <[email protected]>
* fix workload status for multiple revision case Signed-off-by: 天元 <[email protected]> * add CurrentWorkingRevision flag in workload status Signed-off-by: 天元 <[email protected]> Signed-off-by: zzxwill <[email protected]>
to recommend a simple way - Workload Labeling, to easily establish connections between Workloads, Components, AppConfigurations, and pods. Signed-off-by: zzxwill <[email protected]>
2b9cf96
to
34cd4ee
Compare
update the design per the change of unique label crossplane#203 and address comments. Signed-off-by: 天元 <[email protected]> Signed-off-by: zzxwill <[email protected]>
to recommend a simple way - Workload Labeling, to easily
establish connections between Workloads, Components,
AppConfigurations, and pods.
Signed-off-by: Zheng Xi Zhou [email protected]