Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for crossplane validate #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaessert
Copy link

@kaessert kaessert commented Nov 20, 2024

This PR adds functionality for:

  • target for validate
  • option for render and validate to be restricted to specific files with UPTEST_RENDER_FILES

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, left couple of comments

# for `render` and `render.show` command
#
# Note: Extension in this context means:
# - an XRD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that correct statement? XRD seems alien in this context

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, to validate the XR, when running with --include-full-xr for example :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's XR, not XRD ? ;)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XR is part of the output of render and it will be validated against the schema of the extension, in this case the XRD :)

makelib/uptest.mk Show resolved Hide resolved
makelib/uptest.mk Outdated Show resolved Hide resolved
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nit on the comment;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants