Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elasticache/serverless): Add endpoint and reader_endpoint connec… #1576

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

portswigger-tim
Copy link
Contributor

…tionDetails

Description of your changes

Adds connection details for ServerlessCache instances.

Fixes #1568

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@turkenf
Copy link
Collaborator

turkenf commented Nov 25, 2024

/test-examples="examples/elasticache/v1beta1/serverlesscache.yaml"

@portswigger-tim
Copy link
Contributor Author

Here are some references to make help make sure that I got this correct:

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort in this PR @portswigger-tim. Could you please test the resource manually and verify that the connection keys and values ​​​​are coming to the secret correctly? It would be great if you could add the results to the PR description.

@portswigger-tim
Copy link
Contributor Author

Close, but not quite:

Name:         platform-valkey-redis
Namespace:    platform
Labels:       <none>
Annotations:  <none>

Type:  connection.crossplane.io/v1alpha1

Data
====
endpoint_0_address:         64 bytes
reader_endpoint_0_address:  64 bytes

I'm guessing that the type is not quite right on the port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: writeConnectionSecretToRef on ServerlessCache Does Not Write Data to Secret
2 participants