Use gke cloud credentials #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
sboschman
force-pushed
the
use-gke-cloud-credentials
branch
from
5846ebd
to
2f2a8e5
Compare
Signed-off-by: Sverre Boschman <[email protected]>
sboschman
force-pushed
the
use-gke-cloud-credentials
branch
from
2f2a8e5
to
f7f34f8
Compare
ytsarev
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The terraform provider cloud credential secret attribute to connect with GKE is misleading. It tricks Terrajet in generating a k8 secret, which makes it impossible to supply the 'rancher id' of the cloud credential object to use. This pr marks this attribute as non-sensitive, so Terrajet generates a plain string field for it and you are able to supply the cloud credential id.
Fixes #5
Requires #7 to be merged first as this PR build on top of it.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Running crossplane + provider locally in k3s, connecting to an upstream rancher instance with a custom XR.