Bump function-sdk-go to v0.3.0 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires updating to v1 RPC types. The update also brings in the latest crossplane-runtime, and k8s.io v0.30.0 dependencies. v0.31.0 is out, but we can't use them until crossplane-runtime is updated. Signed-off-by: Nic Cope <[email protected]>
We added identical packages to the SDK to avoid folks having to import runtime so commonly in functions. Signed-off-by: Nic Cope <[email protected]>
Pulling in the latest function-sdk-go bumps the Go toolchain in go.mod. This bumps the Go version we use in CI to match. It's unclear to me from a quick skim of the (lengthy) Go toolchain docs if we could just omit our GO_VERSION variable now and let the toolchain directive in go.mod sort it out. Signed-off-by: Nic Cope <[email protected]>
negz
commented
Sep 19, 2024
Comment on lines
+2
to
+4
| # TODO(negz): Update to v1 once we have a build of the crossplane | ||
| # CLI with a fix for the below issue. | ||
| # https://github.com/crossplane/crossplane/issues/5971 |
There was a problem hiding this comment.
I'd like to switch this function to v1 metadata so I can use it in the Crossplane E2E tests to test a fix for this issue. There's a chicken and egg situation though - I need to update crossplane (crank) before I can build the function.
blakeromano
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Closes #24
Closes #16
Closes #17
Closes #27
This requires updating to v1 RPC types.
The update also brings in the latest crossplane-runtime, and k8s.io v0.30.0 dependencies. v0.31.0 is out, but we can't use them until crossplane-runtime is updated. The update also required bumping to the latest Go and golangci-lint versions.
I have: