-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-group): create group form #20
base: main
Are you sure you want to change the base?
Conversation
- 4 screens, with the first screen used as the prompter/the screen to initiate the form. The 3 screens afterwards are the form itself - Some fields are not finished but most text related fields have basic validation
Still needs react context
Added GroupContext in order to retain information inputted by the user when moving in between screens of the Create Group Form, as well as remove the information when leaving the form.
Contains an error of 413 when you submit something in the group form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the file name should use underscores or camel case "create_group_form". (kind of like node_modules)
Overall, all the base functionality works very well, and I love the use of GroupContext. The components "Dropdown" and "TagInput" will also be great for other parts of the app. As for styling, Luke mentioned we'd have a UI designer soon, so we can wait on changing any of the looks.
packages/app/screens/feed/create group form/InitialCreateGroupScreen.js
Outdated
Show resolved
Hide resolved
packages/app/screens/feed/create group form/CreateGroupFormScreen1.js
Outdated
Show resolved
Hide resolved
packages/app/screens/feed/create group form/CreateGroupFormScreen2.js
Outdated
Show resolved
Hide resolved
packages/app/screens/feed/create group form/CreateGroupFormScreen3.js
Outdated
Show resolved
Hide resolved
packages/app/screens/feed/create group form/CreateGroupFormScreen1.js
Outdated
Show resolved
Hide resolved
packages/app/screens/feed/create group form/CreateGroupFormScreen1.js
Outdated
Show resolved
Hide resolved
…into create-group-form
note: on IOS the image picker doesn't work but I think the IOS build is based off of main without the expo image picker plugin. possible IOS rebuild after merging this branch |
altered createGuild post request since insertGuild was very similar (insertGuild post request now deleted) most of it should be the same except the createGuild code in the guilds file in the controllers folder |
banner and icon variables in the guild object are also empty when creating a guild, not sure what to use them for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks good so far! There are just a few things that need to be fixed. Also, remember to look through your code and clean up any console logs and commented-out code for debugging since we don't want that in production code.
Includes:
Notes: