Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-group): create group form #20

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

Conversation

MinT-Napkin
Copy link
Contributor

Includes:

  • Dropdown component
  • TagInput component
  • ImagePicker dependency

Notes:

  • Currently commented out 'Flatlist' in the FeedScreen to test the create group form, but that change has not been committed.

- 4 screens, with the first screen used as the prompter/the screen to initiate the form. The 3 screens afterwards are the form itself

- Some fields are not finished but most text related fields have basic validation
@MinT-Napkin MinT-Napkin marked this pull request as ready for review June 9, 2023 03:22
MinT-Napkin and others added 8 commits June 28, 2023 00:59
Still needs react context
Added GroupContext in order to retain information inputted by the user when moving in between screens of the Create Group Form, as well as remove the information when leaving the form.
Contains an error of 413 when you submit something in the group form
@nappalion nappalion self-requested a review August 10, 2023 21:49
Copy link
Member

@nappalion nappalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file name should use underscores or camel case "create_group_form". (kind of like node_modules)

Overall, all the base functionality works very well, and I love the use of GroupContext. The components "Dropdown" and "TagInput" will also be great for other parts of the app. As for styling, Luke mentioned we'd have a UI designer soon, so we can wait on changing any of the looks.

packages/server/controllers/guild.js Outdated Show resolved Hide resolved
packages/server/routes/api/guild.js Outdated Show resolved Hide resolved
packages/app/utils/GroupContext.js Outdated Show resolved Hide resolved
packages/app/components/Dropdown.js Outdated Show resolved Hide resolved
@MinT-Napkin
Copy link
Contributor Author

note: on IOS the image picker doesn't work but I think the IOS build is based off of main without the expo image picker plugin. possible IOS rebuild after merging this branch

@MinT-Napkin
Copy link
Contributor Author

altered createGuild post request since insertGuild was very similar (insertGuild post request now deleted)

most of it should be the same except the createGuild code in the guilds file in the controllers folder

@MinT-Napkin
Copy link
Contributor Author

banner and icon variables in the guild object are also empty when creating a guild, not sure what to use them for

Copy link
Collaborator

@lxkedinh lxkedinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good so far! There are just a few things that need to be fixed. Also, remember to look through your code and clean up any console logs and commented-out code for debugging since we don't want that in production code.

packages/app/components/TagInput.js Outdated Show resolved Hide resolved
packages/app/components/Dropdown.js Outdated Show resolved Hide resolved
packages/app/utils/GroupContext.js Outdated Show resolved Hide resolved
packages/app/utils/GroupContext.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants