-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle bookmark hook #52
Open
davidgit3000
wants to merge
31
commits into
dev
Choose a base branch
from
toggle-bookmark-hook
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add image Storage file
…toggling functionality
Make some changes about .env and connection refused
fix some issues
…did same with password
small change
…ions of the avatar
Creates conflict when converting to a JSON object
…intital state of isBookmarked field in Article.jsx
fix: added auth token to request in article results page
will ONLY CHECK if user is logged in, but wont throw error if they are not logged in
…every bookmark toggling
…nto toggle-bookmark-hook
change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a custom hook called
useBookmark.jsx
(located insidesrc/hooks
).Article.jsx
/api/users/bookmarks
or/api/bookmarks
).useBookmark
hook.react-hot-toast
(to show error/success message as a Toaster component) andreact-icons
(to display Loading icon in loading state returned fromuseBookmark
)Issue
There arises an issue that I got two toast messages at the same time rather than displaying once