Bugfix composite glyphs #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] Glyphs with references, for example a `i acute` that is assembled (in some fonts) from `dottless i` and `actue` fail to come out with correct bearings. [how] With refenence-glyphs we can not set the width. Handle all referenced glyphs first and then correct the left side bearing. Assumes that no composite glyph references another composite glyph; but that is rather rare. [note] Also fix some code already fixed in PR cpitclaudel#34 here for convenience. Signed-off-by: Fini Jastrow <[email protected]>
[why] The previous fix can distort the composite glyphs if the width change is drastic. [how] It is rather hard to adjust all the layers correctly. The simple approach is to replace the composit glyphs with their actual component-outlines. After that the scaling can happen as any ordinary glyph. The drawback is that the font needs more memory, especially if it has a large amount of composite glyphs. We need to do this in two loops because the unlinking must happen before any referenced glyph has been modified. Signed-off-by: Fini Jastrow <[email protected]>
|
This PR has two commits, both fix the problem commit / solution 1
commit / solution 2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
Glyphs with references, for example a
i acutethat is assembled (in somefonts) from
dottless iandactuefail to come out with correctbearings.
[how]
It is rather hard to adjust all the layers correctly.
The simple approach is to replace the composit glyphs with their actual
component-outlines. After that the scaling can happen as any ordinary
glyph.
The drawback is that the font needs more memory, especially if it has a
large amount of composite glyphs.
We need to do this in two loops because the unlinking must happen before
any referenced glyph has been modified.
[note]
Also fix some code already fixed in PR #34 here for convenience.
Fixes: #29
Fixes: #32
Fixes: fontforge/fontforge#5222
Related: #25