Adding more checks and verbose error message: #1

ocochard · 2021-10-18T13:39:06Z

Testing for TSLOG buffer overflow
Testing for too old loader usage
Renaming USAGE to README.md to be more github friendly

- Testing for TSLOG buffer overflow - Testing for too old loader usage

cperciva · 2021-10-18T16:12:01Z

tslog.sh

+	echo "No loader timestamp detected, are you using up-to-date loader?" 1>&2
+	exit
+fi
+if [ ! -f tslog.thread.start_init ]; then


A better check would be for tsc.end existing -- if we have 'ENTER start_init' but the tslog buffer is truncated before 'EXIT start_init' then we'll have tslog.thread.start_init but not tsc.end.

cperciva · 2021-10-18T16:13:26Z

tslog.sh

@@ -47,6 +49,14 @@ while read THREAD; do
 		echo "$TD $TSC STACK $STACK"
 	done > tslog.thread.$THREAD
 done < threads
+if [ ! -f tslog.thread.0x0 ]; then


We could handle this case by processing what we have (i.e. kernel tslog). It wouldn't give us a complete picture of the boot process, but might still be better than nothing?

Adding more checks and verbose error message:

5604de6

- Testing for TSLOG buffer overflow - Testing for too old loader usage

cperciva reviewed Oct 18, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding more checks and verbose error message: #1

Adding more checks and verbose error message: #1

ocochard commented Oct 18, 2021

cperciva Oct 18, 2021

cperciva Oct 18, 2021

Adding more checks and verbose error message: #1

Are you sure you want to change the base?

Adding more checks and verbose error message: #1

Conversation

ocochard commented Oct 18, 2021

cperciva Oct 18, 2021

Choose a reason for hiding this comment

cperciva Oct 18, 2021

Choose a reason for hiding this comment