Skip to content

Commit

Permalink
Use fresh_perl_like for op/warn.t
Browse files Browse the repository at this point in the history
GH #57

this is fixing two subtests but the test
is still broken for other reasons: utf8 layer.
  • Loading branch information
atoomic committed Jul 18, 2017
1 parent b5b0d2f commit d7aa198
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion t/v5.24.1/C-COMPILED/known_errors.txt
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ op/sub_lval.t TESTS BC issue #277 - sub declaration with :lvalue sh
op/svleak.t COMPAT This test uses XS::APItest, which we don't install during perl install?
op/threads-dirh.t COMPAT We don't support threaded perl in this branch.
op/threads.t COMPAT We don't support threaded perl in this branch.
op/warn.t TESTS BC issue #219 - overload issue
op/warn.t TESTS GH #57 - open qw(:std :utf8) STDOUT issue
op/yadayada.t COMPAT Unimplemented does not display the correct line number
opbasic/magic_phase.t COMPAT Testing BEGIN, INIT, ... phases order, not compatible with B::C
re/overload.t TESTS ?? + BC issue #219 - overload issue
Expand Down
14 changes: 6 additions & 8 deletions t/v5.24.1/t/op/warn.t
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ eval "#line 42 Cholmondeley\n \$\@ = 3; warn";
is @warnings, 2;
is $warnings[1], $warnings[0], 'warn treats $@=3 and $@="3" the same way';

fresh_perl_is(<<'EOF', "should be line 4 at - line 4.\n", {stderr => 1}, "");
fresh_perl_like(<<'EOF', qr{should be line 4 at .* line 4\.}, {stderr => 1}, "");
${
foo
} = "should be line 4";
Expand All @@ -204,13 +204,11 @@ EOF

TODO: {
local $::TODO = "Line numbers don't yet match up for \${ EXPR }";
my $expected = <<'EOF';
line 1 at - line 1.
line 4 at - line 3.
also line 4 at - line 4.
line 5 at - line 5.
EOF
fresh_perl_is(<<'EOF', $expected, {stderr => 1}, "");
my $expected = qr{line 1 at .* line 1.
line 4 at .* line 2.
also line 4 at .* line 4.
line 5 at .* line 5.}m;
fresh_perl_like(<<'EOF', $expected, {stderr => 1}, "");
warn "line 1";
(${
foo
Expand Down

0 comments on commit d7aa198

Please sign in to comment.