Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: updated to sp1 v3.0.0 and removed git-lfs #77

Merged
merged 14 commits into from
Oct 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .gitattributes

This file was deleted.

22 changes: 3 additions & 19 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:
- 'bun.lockb'
env:
FOUNDRY_PROFILE: ci
SP1_OPERATOR_REV: 0c68154522413f20e078726014d753bbedcdbd2b
SP1_OPERATOR_REV: 7b302f7493cfd7dbcbcd7c8ece5ba1e57d6c8104
permissions:
contents: read

Expand Down Expand Up @@ -54,18 +54,6 @@ jobs:
- name: Checkout sources
uses: actions/checkout@v4

- name: Create LFS file list
run: git lfs ls-files --long | cut -d ' ' -f1 | sort > .lfs-assets-id
- name: LFS Cache
uses: actions/cache@v4
with:
path: .git/lfs/objects
key: ${{ runner.os }}-lfs-${{ hashFiles('.lfs-assets-id') }}
restore-keys: |
${{ runner.os }}-lfs-
- name: Git LFS Pull
run: git lfs pull

- name: Setup Go
uses: actions/setup-go@v4
with:
Expand All @@ -80,8 +68,7 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
override: true
toolchain: nightly-2024-10-11

- name: "Cache Operator"
id: cache-operator
Expand All @@ -97,14 +84,11 @@ jobs:
curl -L https://sp1.succinct.xyz | bash
~/.sp1/bin/sp1up
~/.sp1/bin/cargo-prove prove --version
- name: Install SP1 circuit artifacts (plonky only)
run: |
mkdir -p ~/.sp1/circuits
mv e2e/artifacts/circuits/v2.0.0 ~/.sp1/circuits/v2.0.0
- name: Install operator
if: steps.cache-operator.outputs.cache-hit != 'true'
uses: actions-rs/cargo@v1
with:
toolchain: nightly-2024-10-11
command: install
args: --git https://github.com/cosmos/sp1-ics07-tendermint --rev ${{ env.SP1_OPERATOR_REV }} sp1-ics07-tendermint-operator --bin operator --locked

Expand Down
18 changes: 5 additions & 13 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,6 @@ This project is structered as a [foundry](https://getfoundry.sh/) project with t
| `ICS27Controller.sol` | IBC Eureka interchain accounts controller. | ❌ |
| `ICS27Host.sol` | IBC Eureka interchain accounts host. | ❌ |

## Cloning the Repository

This repository contains large files stored using Git LFS. These are only needed for the GitHub workflows (and are not needed for local development/testing) until [succinctlabs/sp1#1565](https://github.com/succinctlabs/sp1/issues/1565) is resolved. You can clone the repository without the large files by running the following command:

```sh
GIT_LFS_SKIP_SMUDGE=1 git clone https://github.com/cosmos/solidity-ibc-eureka
```

## Requirements

- [Foundry](https://book.getfoundry.sh/getting-started/installation)
Expand Down Expand Up @@ -129,11 +121,11 @@ The contracts in this repository are benchmarked end-to-end using foundry. The f

| **Contract** | **Method** | **Description** | **Gas** |
|:---:|:---:|:---:|:---:|
| `ICS20Transfer.sol` | `sendTransfer` | Initiating an IBC transfer with an `ERC20`. | 241,674 |
| `ICS26Router.sol` | `recvPacket` | Receiving _back_ an `ERC20` token. | 620,758 |
| `ICS26Router.sol` | `recvPacket` | Receiving a _new_ Cosmos token for the first time. (Deploying an `ERC20` contract) | 1,521,712 |
| `ICS26Router.sol` | `ackPacket` | Acknowledging an ICS20 packet. | 508,261 |
| `ICS26Router.sol` | `timeoutPacket` | Timing out an ICS20 packet | 555,121 |
| `ICS20Transfer.sol` | `sendTransfer` | Initiating an IBC transfer with an `ERC20`. | 240,120 |
| `ICS26Router.sol` | `recvPacket` | Receiving _back_ an `ERC20` token. | 628,403 |
| `ICS26Router.sol` | `recvPacket` | Receiving a _new_ Cosmos token for the first time. (Deploying an `ERC20` contract) | 1,525,837 |
| `ICS26Router.sol` | `ackPacket` | Acknowledging an ICS20 packet. | 512,695 |
| `ICS26Router.sol` | `timeoutPacket` | Timing out an ICS20 packet | 563,571 |

## License

Expand Down
5 changes: 5 additions & 0 deletions abi/IBCERC20.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
"type": "address",
"internalType": "contract IICS20Transfer"
},
{
"name": "escrow_",
"type": "address",
"internalType": "contract IEscrow"
},
{
"name": "ibcDenom_",
"type": "string",
Expand Down
40 changes: 13 additions & 27 deletions abi/ICS20Transfer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,19 @@
],
"stateMutability": "nonpayable"
},
{
"type": "function",
"name": "escrow",
"inputs": [],
"outputs": [
{
"name": "",
"type": "address",
"internalType": "address"
}
],
"stateMutability": "view"
},
{
"type": "function",
"name": "onAcknowledgementPacket",
Expand Down Expand Up @@ -575,33 +588,6 @@
],
"anonymous": false
},
{
"type": "error",
"name": "AddressEmptyCode",
"inputs": [
{
"name": "target",
"type": "address",
"internalType": "address"
}
]
},
{
"type": "error",
"name": "AddressInsufficientBalance",
"inputs": [
{
"name": "account",
"type": "address",
"internalType": "address"
}
]
},
{
"type": "error",
"name": "FailedInnerCall",
"inputs": []
},
{
"type": "error",
"name": "ICS20BytesSliceOutOfBounds",
Expand Down
Loading
Loading