Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove sdk coin library #60

Merged
merged 5 commits into from
Aug 28, 2024
Merged

chore: remove sdk coin library #60

merged 5 commits into from
Aug 28, 2024

Conversation

crodriguezvega
Copy link
Contributor

closes: #55

gjermundgaraba
gjermundgaraba approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! LGTM!
This makes everything so much cleaner (and not only the removal of the back-and-forth conversion).

.github/workflows/e2e.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
e2e/interchaintestv8/ibc_eureka_test.go Show resolved Hide resolved
e2e/interchaintestv8/ibc_eureka_test.go Outdated Show resolved Hide resolved
e2e/interchaintestv8/ibc_eureka_test.go Show resolved Hide resolved
e2e/interchaintestv8/testvalues/values.go Show resolved Hide resolved
src/utils/IBCERC20.sol Show resolved Hide resolved
@gjermundgaraba gjermundgaraba merged commit ee85ba6 into main Aug 28, 2024
8 checks passed
@gjermundgaraba gjermundgaraba deleted the carlos/55-remove-sdkcoin-library branch August 28, 2024 08:18
@crodriguezvega crodriguezvega mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaSripal AdityaSripal AdityaSripal left review comments

@gjermundgaraba gjermundgaraba gjermundgaraba approved these changes

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
IBC-GO Eureka
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove SdkCoin library
3 participants
@crodriguezvega @gjermundgaraba @AdityaSripal