Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: make SP1_PRIVATE_KEY optional when running mock #52

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

gjermundgaraba
Copy link
Contributor

Make SP1_PRIVATE_KEY only mandatory in the e2e tests when using network.

The abi changes are just something that should have been included in main already, not related to the private key changes.

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. We can merge when CI passes.

@gjermundgaraba gjermundgaraba merged commit 0e26d3d into main Aug 20, 2024
8 checks passed
@gjermundgaraba gjermundgaraba deleted the gjermund/optional-sp1-private-key branch August 20, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants