refactor: renamed sdkCoin functions to camelCase #50
Conversation
There was a problem hiding this comment.
Thank you for the contribution. Looks good, I made an alternate naming suggestion, I don't know what other's think @gjermundgaraba @sangier. We can merge this when the CI passes
There was a problem hiding this comment.
@MukulKolpe Not 100% sure why the e2e test fails, but I can check that quickly here.
It looks like the linter is also complaining, however, so try to run just lint and make any changes it suggests :)
|
@MukulKolpe, I just checked it out locally, and I guess the e2e fails are due to an issue in our CI pipeline with some secrets not being able to run. I ran one of the e2e tests myself, so I believe when everything else is fixed here this can be merged anyway :) |
|
Yes, created an issue (#54) about this @gjermundgaraba, we can merge this PR without the e2es passing |
|
Thanks @gjermundgaraba, @srdtrk! |
|
@MukulKolpe, it looks like it is failing on the listing. Try to run |
|
Thank you for the PR, @MukulKolpe, but at the end it turned out that we don't need this SDK coin library, so it will be removed. |
Updated
_ERC20ToSdkCoin_ConvertAmountand_SdkCoinToERC20_ConvertAmounttoconvertAmountFromERC20andconvertAmountToERC20respectively, aligning them with standard camelCase naming convention to account for standards used in libraries.closes: #32