Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: relocate timeout checks and use get app function #49

Merged
merged 4 commits into from
Aug 19, 2024
Merged

imp: relocate timeout checks and use get app function #49

merged 4 commits into from
Aug 19, 2024

Conversation

crodriguezvega
Copy link
Contributor

Some small improvements I noticed while walkthrough the code:

  • emit IBCAppAdded event at the end of the function.
  • Check timeout earlier in the functions.
  • Reuse getIBCApp function.

srdtrk
srdtrk approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@srdtrk srdtrk merged commit de7fae4 into main Aug 19, 2024
8 checks passed
@srdtrk srdtrk deleted the carlos/reorder-timeout-checks branch August 19, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srdtrk srdtrk srdtrk approved these changes

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crodriguezvega @srdtrk