Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: Convert error to Acknowledgements #115

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

DRAFT: Convert error to Acknowledgements #115

wants to merge 2 commits into from
+62 −35

Conversation

AdityaSripal
Copy link
Member

@AdityaSripal AdityaSripal commented Nov 20, 2024 •
edited
Loading

Description

closes: #112

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk will be requested when the pull request is marked ready for review srdtrk is a code owner

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba will be requested when the pull request is marked ready for review gjermundgaraba is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Catch errors in App callbacks
1 participant
@AdityaSripal