-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timeout validation for timeout height #556
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
+ Coverage 72.70% 72.90% +0.19%
==========================================
Files 126 126
Lines 15550 15594 +44
==========================================
+ Hits 11306 11369 +63
+ Misses 4244 4225 -19
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
this is happening in other PRs too, will investigate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* fix timeout * add changelog * fix comments * fix error checking in a unit test --------- Co-authored-by: Philippe Laferrière <[email protected]>
Closes: #555
Closes: #443
Description
Only when both the timeout height and timestamp have not passed yet, the timeout handler returns an error
PacketTimeoutNotReached
.PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.