Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout validation for timeout height #556

Merged
merged 5 commits into from
Mar 22, 2023

Conversation

yito88
Copy link
Contributor

@yito88 yito88 commented Mar 17, 2023

Closes: #555
Closes: #443

Description

Only when both the timeout height and timestamp have not passed yet, the timeout handler returns an error PacketTimeoutNotReached.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@yito88 yito88 changed the title Fix timeout handler for timeout height Fix timeout validation for timeout height Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 98.38% and project coverage change: +0.19 🎉

Comparison is base (7be8927) 72.70% compared to head (1807704) 72.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
+ Coverage   72.70%   72.90%   +0.19%     
==========================================
  Files         126      126              
  Lines       15550    15594      +44     
==========================================
+ Hits        11306    11369      +63     
+ Misses       4244     4225      -19     
Impacted Files Coverage Δ
crates/ibc/src/core/ics04_channel/error.rs 0.00% <ø> (ø)
...ates/ibc/src/core/ics04_channel/handler/timeout.rs 93.71% <98.38%> (+4.45%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@plafer
Copy link
Contributor

plafer commented Mar 20, 2023

@yito88 any idea why the CI suddenly fails?

this is happening in other PRs too, will investigate

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@plafer plafer merged commit e7f02ac into cosmos:main Mar 22, 2023
@yito88 yito88 deleted the yuji/fix_timeout branch March 22, 2023 19:53
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* fix timeout

* add changelog

* fix comments

* fix error checking in a unit test

---------

Co-authored-by: Philippe Laferrière <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validating timeout failed when height timeout implement missing timeout packet test
2 participants