-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: adding runtime Environment to icacontroller #7587
Open
damiannolan
wants to merge
22
commits into
marko/gomod_change
Choose a base branch
from
damian/runtime-env
base: marko/gomod_change
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe we need to update linter versions or something in CI. Not sure what the arm64 build failure is too. Probably need to look into it |
damiannolan
changed the title
feat: adding runtime Environment
feat: adding runtime Environment to icacontroller
Nov 25, 2024
chatton
requested review from
AdityaSripal,
srdtrk,
chatton,
DimitrisJim,
gjermundgaraba and
bznein
as code owners
November 27, 2024 12:02
chatton
changed the title
feat: adding runtime Environment to icacontroller
[WIP] feat: adding runtime Environment to icacontroller
Nov 27, 2024
Quality Gate passed for 'ibc-go'Issues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
R4R only for E2Es, do not review
Initially adding runtime Environment to ica to address events propagation issue with unwrapping context.
All tests seem to be now passing on this branch,
except for some build err in e2e unit tests which we will address separately.ref: #7223
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.