Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: adding runtime Environment to icacontroller #7587

Open
wants to merge 22 commits into
base: marko/gomod_change
Choose a base branch
from

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Nov 21, 2024

Description

R4R only for E2Es, do not review

Initially adding runtime Environment to ica to address events propagation issue with unwrapping context.
All tests seem to be now passing on this branch, except for some build err in e2e unit tests which we will address separately.

ref: #7223


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@damiannolan
Copy link
Member Author

Maybe we need to update linter versions or something in CI. Not sure what the arm64 build failure is too. Probably need to look into it

@damiannolan damiannolan changed the title feat: adding runtime Environment feat: adding runtime Environment to icacontroller Nov 25, 2024
@chatton chatton marked this pull request as ready for review November 27, 2024 12:02
@chatton chatton changed the title feat: adding runtime Environment to icacontroller [WIP] feat: adding runtime Environment to icacontroller Nov 27, 2024
Copy link

sonarcloud bot commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants