Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement landlord button on ApartmentCard #339

Merged
merged 10 commits into from
Feb 19, 2024
Merged

Conversation

ggsawatyanon
Copy link
Contributor

@ggsawatyanon ggsawatyanon commented Feb 10, 2024

Summary

This pull request implements a landlord button on ApartmentCard.

  • implemented landlord button on ApartmentCard
  • made button display the landlord name and redirect to the landlord page
  • made sure the card is not highlighted red when hovering over the landlord button

Test Plan

image

Card highlighted red when hovering over it:
image

Card no longer highlighted red when hovering on landlord button:
image

Mobile display:
image

Notes

Breaking Changes

@dti-github-bot
Copy link
Member

dti-github-bot commented Feb 10, 2024

[diff-counting] Significant lines: 73.

Copy link
Contributor

@dan-ieljin dan-ieljin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully functional and nice styling

@dan-ieljin dan-ieljin merged commit 6c108dc into main Feb 19, 2024
5 checks passed
@dan-ieljin dan-ieljin deleted the landlordLabelApartmentCard branch February 19, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants