Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Saved Property sort-by button for review count and average rating #336

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

mluo24
Copy link
Contributor

@mluo24 mluo24 commented Dec 2, 2023

Summary

This adds the ability to sort the saved apartments by either the number of reviews and the average rating of the apartment.

A lot of things had to change to make this work, including a bunch of async await calls, so loading times might kind of screwed.

Test Plan

image image

@dti-github-bot
Copy link
Member

dti-github-bot commented Dec 2, 2023

[diff-counting] Significant lines: 189.

Copy link

github-actions bot commented Dec 2, 2023

Visit the preview URL for this PR (updated for commit b087dc3):

https://cu-apts-staging--pr336-saved-property-sortb-7l77h19g.web.app

(expires Sat, 09 Dec 2023 05:18:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 096ac87b789b31770a01964fe0aaa92d563b9353

Copy link
Contributor

@ggsawatyanon ggsawatyanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great and is really useful.

@ggsawatyanon ggsawatyanon merged commit 983ff44 into main Apr 17, 2024
5 checks passed
@ggsawatyanon ggsawatyanon deleted the saved-property-sortby-button branch April 17, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants