-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saved property landlord UI #333
Conversation
[diff-counting] Significant lines: 248. |
Visit the preview URL for this PR (updated for commit a0077e9): https://cu-apts-staging--pr333-saved-property-landl-4su0vsck.web.app (expires Fri, 08 Dec 2023 21:40:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 096ac87b789b31770a01964fe0aaa92d563b9353 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on creating new component for bookmark page. This PR creates a foundation for the upcoming tasks in the future:
- Enable save/unsave feature in the bookmarkAptCard --> Should handle onClick function
- Also show saved landlords, now only saved apartments are shown
… saved-property-landlord-ui # Conflicts: # frontend/src/pages/BookmarksPage.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work Miranda! These changes are definitely super needed and will really improve the user experience. I will say that for the backend api you created, surrounding it in a try/catch might make it a little safer. Also, deleting the token as it isn't used in the BookmarksPage.tsx. Overall great work and looking forward to seeing this PR merged soon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
This pull request introduces a new feature to enhance user profiles by enabling the saving and management of favorite apartments. The main additions include the implementation of an expand and collapse button for saved apartments within the user profile and the incorporation of a dedicated endpoint to fetch saved properties (as I don't believe it existed before).
Test Plan
Notes
Currently does not have the correct data. Also there may be some mobile formatting issues.