[WIP] Edit review pop-up model #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 306. |
There was a problem hiding this comment.
Great work Cyrus! I'm looking forward to this PR being finished as it is definitely needed and also will also improve the overall experience for the user since they can edit their own reviews. I really like the documentation that you have also added throughout the PR. Looking forward to it!
mluo24
reviewed
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is the first step towards implementing the edit review pop-up model within the Profile Page.
This is what has been done so far:
Screen.Recording.2023-12-01.at.2.27.14.AM.mov
I am still working on how to populate with existing review data. I have condensed the data into FormData which is correct format but for some reason the hearts are not changing even when being updated.
Test Plan
Tested out the various actions.