Skip to content

Commit

Permalink
build: Update Dockerfile build argument defaults
Browse files Browse the repository at this point in the history
  • Loading branch information
Eta0 committed Oct 31, 2024
1 parent ccaa59d commit 66b413d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions Dockerfile.ubuntu20
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
ARG CUDA_VERSION_MINOR=11.7.1
ARG BASE_IMAGE=nvidia/cuda:${CUDA_VERSION_MINOR}-cudnn8-devel-ubuntu20.04
ARG CUDA_VERSION_MINOR=12.4.1
ARG BASE_IMAGE=nvidia/cuda:${CUDA_VERSION_MINOR}-cudnn-devel-ubuntu20.04
FROM ${BASE_IMAGE} as base

ARG CUDA_VERSION_MAJOR=11.7
ARG TARGET_NCCL_VERSION=2.14.3-1
ARG CUDA_VERSION_MAJOR=12.4
ARG TARGET_NCCL_VERSION=2.23.4-1

ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get -qq update && \
Expand Down
8 changes: 4 additions & 4 deletions Dockerfile.ubuntu22
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
ARG CUDA_VERSION_MINOR=12.2.2
ARG BASE_IMAGE=nvidia/cuda:${CUDA_VERSION_MINOR}-cudnn8-devel-ubuntu22.04
ARG CUDA_VERSION_MINOR=12.4.1
ARG BASE_IMAGE=nvidia/cuda:${CUDA_VERSION_MINOR}-cudnn-devel-ubuntu22.04
FROM ${BASE_IMAGE} as base

Check warning on line 3 in Dockerfile.ubuntu22

View workflow job for this annotation

GitHub Actions / cu126 / Building Dockerfile.ubuntu22

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 3 in Dockerfile.ubuntu22

View workflow job for this annotation

GitHub Actions / cu124 / Building Dockerfile.ubuntu22

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

ARG CUDA_VERSION_MAJOR=12.2
ARG TARGET_NCCL_VERSION=2.19.3-1
ARG CUDA_VERSION_MAJOR=12.4
ARG TARGET_NCCL_VERSION=2.23.4-1

ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get -qq update && \
Expand Down

0 comments on commit 66b413d

Please sign in to comment.