Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sections trim incorrectly #6

Open
sorghumking opened this issue Jun 17, 2020 · 1 comment
Open

Sections trim incorrectly #6

sorghumking opened this issue Jun 17, 2020 · 1 comment

Comments

@sorghumking
Copy link
Collaborator

Section images that are vertically oriented at import-time behave badly when trimmed via Trim Sections. Both ends of the section are trimmed, and the Trim Sections dialog sometimes displays "???" in the trim length field.

@sorghumking
Copy link
Collaborator Author

Turns out this issue goes deeper than trimming. The problem images (JPEGs) were rotated to horizontal orientation and still exhibited the bad trim behavior. Furthermore, their lengths at import time were incorrect, reflecting the width of the core instead of its length.

Some digging revealed that the width and height in the JPEG header aren't always sufficient. JPEGs can include EXIF data, which has an orientation property defining rotation and flipping of the source pixels. The problem JPEGs had orientation value 8 aka LeftBottom, indicating the source pixels should be rotated 90 degrees clockwise.

At present Corelyzer makes no attempt to read and apply EXIF orientation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant